docs: reference shared verification checks #118

jercik · 2026-10-04T20:10:23Z

jercik commented

2026-10-04 20:10:23 +00:00

Points verification to the shared reengineering checks identified in #116, retaining the program-specific snapshot, test, rejection and confirmed-design methods without a second category list.

Points verification to the shared reengineering checks identified in [#116](https://code.j4k.dev/j4k-oss/agent-skills/pulls/116), retaining the program-specific snapshot, test, rejection and confirmed-design methods without a second category list.

jercik added 1 commit

2026-10-04 20:10:23 +00:00

docs: reference shared verification checks

commit-msg / commitlint (pull_request) Successful in 28s

Details

Node tests / node:test (pull_request) Successful in 2m14s

Details

Review / Review (pull_request_target) Successful in 5m39s

Details

d6686d3eb0

jercik referenced this pull request

2026-10-04 20:11:01 +00:00

docs: clarify existing implementation ADR guidance #116

forgejo-actions commented

2026-10-04 20:15:59 +00:00

Review 01M4491BF70H7WH3646Y8D6HCZ — head 22c3b3126a359ee540dbfb0782aac828bbebecec

Review — j4k-oss/agent-skills @ `def67b6a7b`

Scope: diff against base tree 4b221c8e8dd6
Status: dispatched — coverage complete (5/5 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

general-bug (whole/default): unit-failed
writing-quality (whole/default): unit-failed
test-trimming (whole/default): unit-failed
restated-sets (whole/default): unit-failed
project-docs (whole/default): unit-failed

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M4491BHT7YTMGAWSEG7J0XMC
Accounting: complete
Slot health: general-bug (whole/default): unit-failed; writing-quality (whole/default): unit-failed; test-trimming (whole/default): unit-failed; restated-sets (whole/default): unit-failed; project-docs (whole/default): unit-failed

lens	part	arm	unit status	runs	loss
general-bug	whole	default	unit-failed	1	no
writing-quality	whole	default	unit-failed	1	no
test-trimming	whole	default	unit-failed	1	no
restated-sets	whole	default	unit-failed	1	no
project-docs	whole	default	unit-failed	1	no

general-bug run 01M4491BHVAZBB0HB8TEHFY4Z2: sandbox infrastructure failed.
writing-quality run 01M4491BHW7W0TMV0M4RCN9FTH: sandbox infrastructure failed.
test-trimming run 01M4491BHYSGTAD9Y3N4VWE7TK: sandbox infrastructure failed.
restated-sets run 01M4491BHZXNHBH0V16T4S0ZN6: sandbox infrastructure failed.
project-docs run 01M4491BJ0HQF9JTZSMPZ1QYV3: sandbox infrastructure failed.

**Review** `01M4491BF70H7WH3646Y8D6HCZ` — head `22c3b3126a359ee540dbfb0782aac828bbebecec` # Review — j4k-oss/agent-skills @ def67b6a7b0f Scope: diff against base tree `4b221c8e8dd6` Status: dispatched — coverage complete (5/5 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): unit-failed - writing-quality (whole/default): unit-failed - test-trimming (whole/default): unit-failed - restated-sets (whole/default): unit-failed - project-docs (whole/default): unit-failed ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M4491BHT7YTMGAWSEG7J0XMC Accounting: complete Slot health: general-bug (whole/default): unit-failed; writing-quality (whole/default): unit-failed; test-trimming (whole/default): unit-failed; restated-sets (whole/default): unit-failed; project-docs (whole/default): unit-failed | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | unit-failed | 1 | no | | writing-quality | whole | default | unit-failed | 1 | no | | test-trimming | whole | default | unit-failed | 1 | no | | restated-sets | whole | default | unit-failed | 1 | no | | project-docs | whole | default | unit-failed | 1 | no | - general-bug run 01M4491BHVAZBB0HB8TEHFY4Z2: sandbox infrastructure failed. - writing-quality run 01M4491BHW7W0TMV0M4RCN9FTH: sandbox infrastructure failed. - test-trimming run 01M4491BHYSGTAD9Y3N4VWE7TK: sandbox infrastructure failed. - restated-sets run 01M4491BHZXNHBH0V16T4S0ZN6: sandbox infrastructure failed. - project-docs run 01M4491BJ0HQF9JTZSMPZ1QYV3: sandbox infrastructure failed.

forgejo-actions reviewed

2026-10-04 20:16:00 +00:00

skills/reengineer-program/references/implementation.md Outdated

					
				@ -27,3 +27,1 @@

				- **Unchanged promises:** compare kept surfaces with their snapshots and run the surviving tests against the rebuilt program.

				- **Dropped promises:** demonstrate that each dropped situation is rejected or unrepresentable.

				- **Replaced or added promises:** verify against the confirmed design, not the old implementation.

				Apply the shared reengineering skill's verification checks. Compare kept surfaces with their snapshots and run the surviving tests against the rebuilt program. Demonstrate that each dropped situation is rejected or unrepresentable. Verify replacements and additions against the confirmed design, not the old implementation.

medium — The Verify paragraph repeats the shared verification check set

The program skill copies the complete verification check set after directing the implementer to the shared skill. A change to the shared checks would leave this procedure with a second, silently stale account of what to verify. The defining source, skills/reengineering/SKILL.md, has retained promises, dropped promises, and replaced or added promises. This paragraph covers kept surfaces, dropped situations, and replacements and additions, respectively; no member appears in only one list, so the copy currently agrees. Keep the pointer to the shared checks and remove the three category-specific restatements here; the local Subtract and Rebuild sections already carry the program-specific snapshot, test, dropped-state, and confirmed-design instructions. I read both skills and the full changed file, and traced the reengineer-program entry skill's required call to reengineering. This is active procedural prose, its reader can open that required skill, and it is neither a dated record nor a table of contents. The source and copy as read establish the duplication; a different effective source for verification would refute it.

lens restated-sets · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M448RYF8AVARG4K5SCYJVSP2 of review 01M448M2KZ0TD7FDZ173T61814

**medium** — The Verify paragraph repeats the shared verification check set > The program skill copies the complete verification check set after directing the implementer to the shared skill. A change to the shared checks would leave this procedure with a second, silently stale account of what to verify. The defining source, skills/reengineering/SKILL.md, has retained promises, dropped promises, and replaced or added promises. This paragraph covers kept surfaces, dropped situations, and replacements and additions, respectively; no member appears in only one list, so the copy currently agrees. Keep the pointer to the shared checks and remove the three category-specific restatements here; the local Subtract and Rebuild sections already carry the program-specific snapshot, test, dropped-state, and confirmed-design instructions. I read both skills and the full changed file, and traced the reengineer-program entry skill's required call to reengineering. This is active procedural prose, its reader can open that required skill, and it is neither a dated record nor a table of contents. The source and copy as read establish the duplication; a different effective source for verification would refute it. lens `restated-sets` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M448RYF8AVARG4K5SCYJVSP2` of review `01M448M2KZ0TD7FDZ173T61814`

👍 1

Fixed in 22c3b3126a: Verify only invokes the shared check set. Snapshot comparison stays with Subtract; surviving-test, dropped-state and confirmed-design methods remain in their local procedural sections.

Fixed in 22c3b3126a359ee540dbfb0782aac828bbebecec: Verify only invokes the shared check set. Snapshot comparison stays with Subtract; surviving-test, dropped-state and confirmed-design methods remain in their local procedural sections.

jercik marked this conversation as resolved

jercik added 1 commit

2026-10-04 20:17:37 +00:00

fix: verification should load its shared check set

commit-msg / commitlint (pull_request) Successful in 14s

Details

Node tests / node:test (pull_request) Successful in 2m16s

Details

Review / Review (pull_request_target) Failing after 2m40s

Details

22c3b3126a