feat: remove four superseded reference skills #33
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/remove-reference-skills"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Skills-triage batch 1 (first half): removes
fastify-zod-reference,typescript-magician,to-prd, andto-issues— imported reference material that duplicates or contradicts the align rule corpus (default exports, hand-rolled type guards over Zod, baretsc --noEmit, npm flows on a pnpm fleet, a dead/setup-matt-pocock-skillsprerequisite). Nothing else in the repo references any of the four. Thenodeskill's trim to its unique subjects follows as its own PR.Approach review: The approach looks good.
This is a pure removal: 37 files deleted, zero added or modified lines, and each of the four skill directories (
fastify-zod-reference,typescript-magician,to-prd,to-issues) is removed in full with no orphaned files left behind. That matches the stated intent exactly.Deletion is the right mechanism here rather than the alternatives:
skills/is the selectable skill name anddescriptionis the only picker metadata, there is no deprecation or tombstone mechanism in this source format that would be more graceful than removing the directory. A stubSKILL.mdmarked deprecated would keep the entry in the picker and inaxskills sync's managed copies, which is strictly worse than removing it.tsc --noEmit, npm flows on a pnpm fleet, a dead/setup-matt-pocock-skillsprerequisite) is a content judgment, not an approach one.nodeskill trim as a separate PR keeps each change independently reviewable and revertable, which is appropriate for bulk content removal of this size.I confirmed nothing else in the repository references the removed skills by name (including
setup-matt-pocock), so no dangling cross-references or README entries are left to clean up. Git history preserves the removed content if any of it needs to be recovered later.No material alternative to suggest.
Approach review by Claude Code Opus (opus)
Summary: No actionable issues found.
This PR is a pure deletion of four skill directories (37 files, 13,392 deletions, no additions or renames). Verification performed against the working tree:
.git) forfastify-zod-reference,typescript-magician,to-prd,to-issues, andsetup-matt-pocockreturns nothing, so no surviving skill, README section, workflow, or hook links to the removed material. The README documents the layout generically (skills/<skill-name>/SKILL.md) rather than enumerating skills, so it needs no update..forgejo/workflows/node-test.ymlguards against stale inputs by comparing the tracked*.test.{js,cjs,mjs,ts,cts,mts}andpackage.jsonsets against a baked-in base64 list. Post-deletion,git ls-filesfor those globs still yields exactlyskills/node/rules/assets/graceful-server.test.ts, matching the encoded expectation — the deletions are all.md, so the staleness check does not trip and noj4k-alignrefresh is required.to-prdandto-issuesskills both instruct the agent to run/setup-matt-pocock-skills, a command that exists nowhere in this repository;typescript-magicianteaches a hand-rolledisUser(value): value is Userguard and a baretsc --noEmitloop, which conflict with the align corpus's Parse-Don't-Validate rule.skills/, with no orphaned assets or partially-deleted rule trees.Code review by Claude Code Opus (opus)