j4k-oss/fta-check
Watch
2
0
Fork
You've already forked fta-check
 0
Code Issues Pull requests Releases 5 Packages 1 Activity Actions

fix(deps): update commander to v15 #4

Merged
jercik merged 1 commit from fix/commander-15 into main 2026-10-21 13:50:27 +00:00
Conversation 1 Commits 1 Files changed 2 +15 -15
jercik commented 2026-10-21 13:48:02 +00:00
Owner

Updates commander and @commander-js/extra-typings from 14 to 15. Commander 14 is now in maintenance and gets security fixes only, until May 2027.

Commander 15 is ESM only and needs Node 22.12 or newer. fta-check is already ESM and requires Node 24.15, and src/cli.ts uses none of the other changed behavior (--no-* defaults, commander/esm.mjs). Against a sample project, 47 invocations of the built CLI give the same stdout and exit status before and after. Stderr matches too, except that the stack trace printed for an invalid --threshold now shows commander 15's frames.

Merging cuts 1.5.11, which also goes to npmjs through the GitHub mirror.

Updates `commander` and `@commander-js/extra-typings` from 14 to 15. Commander 14 is now in maintenance and gets security fixes only, until May 2027. Commander 15 is ESM only and needs Node 22.12 or newer. fta-check is already ESM and requires Node 24.15, and `src/cli.ts` uses none of the other changed behavior (`--no-*` defaults, `commander/esm.mjs`). Against a sample project, 47 invocations of the built CLI give the same stdout and exit status before and after. Stderr matches too, except that the stack trace printed for an invalid `--threshold` now shows commander 15's frames. Merging cuts 1.5.11, which also goes to npmjs through the GitHub mirror.
fix(deps): update commander to v15
All checks were successful
Checks / pr-flow-canary (pull_request) Has been skipped
Details
Checks / reuse (pull_request) Successful in 6s
Details
commit-msg / commitlint (pull_request) Successful in 17s
Details
Checks / quality-checks (24.15.0) (pull_request) Successful in 34s
Details
Checks / quality-checks (26.5.0) (pull_request) Successful in 35s
Details
Dedupe check / dedupe-check (pull_request) Successful in 54s
Details
Review / Review (pull_request_target) Successful in 1m21s
Details
9ec67c62e3
 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
forgejo-actions commented 2026-10-21 13:49:22 +00:00

Review 01M5FBG7EMH0SMRWNCVY0448GR — head 9ec67c62e3e2dfe853abf0e6f25fe8fd543b1bb5

Review — j4k-oss/fta-check @ 20f9fee31b

Scope: diff against base tree 5ad5c5fddde8
Status: dispatched — coverage complete (3/3 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

  • restated-sets (whole/default): no-claims
  • general-bug (whole/default): no-claims
  • unix-cli (whole/default): no-claims
  • writing-quality: skipped-by-dispatch — only dependency manifest and lockfile changed; no prose
  • test-trimming: skipped-by-dispatch — no tests changed
  • project-docs: skipped-by-dispatch — no documentation changed
  • use-effect: skipped-by-dispatch — no React code or Effects changed; only commander dependency versions
  • react: skipped-by-dispatch — no React components changed; only commander dependency versions

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (0)
  • duplicate-of (0)
  • unadjudicated (0)

Coverage

Coverage pass: 01M5FBGP0WV3Y5W1QBE24TDV6J
Accounting: complete
Slot health: healthy

lens part arm unit status runs loss
restated-sets whole default no-claims 1 no
general-bug whole default no-claims 1 no
unix-cli whole default no-claims 1 no
  • writing-quality — skipped-by-dispatch: only dependency manifest and lockfile changed; no prose
  • test-trimming — skipped-by-dispatch: no tests changed
  • project-docs — skipped-by-dispatch: no documentation changed
  • use-effect — skipped-by-dispatch: no React code or Effects changed; only commander dependency versions
  • react — skipped-by-dispatch: no React components changed; only commander dependency versions
<!-- review:summary --> **Review** `01M5FBG7EMH0SMRWNCVY0448GR` — head `9ec67c62e3e2dfe853abf0e6f25fe8fd543b1bb5` # Review — j4k-oss/fta-check @ 20f9fee31b1e Scope: diff against base tree `5ad5c5fddde8` Status: dispatched — coverage complete (3/3 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - restated-sets (whole/default): no-claims - general-bug (whole/default): no-claims - unix-cli (whole/default): no-claims - writing-quality: skipped-by-dispatch — only dependency manifest and lockfile changed; no prose - test-trimming: skipped-by-dispatch — no tests changed - project-docs: skipped-by-dispatch — no documentation changed - use-effect: skipped-by-dispatch — no React code or Effects changed; only commander dependency versions - react: skipped-by-dispatch — no React components changed; only commander dependency versions ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M5FBGP0WV3Y5W1QBE24TDV6J Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | restated-sets | whole | default | no-claims | 1 | no | | general-bug | whole | default | no-claims | 1 | no | | unix-cli | whole | default | no-claims | 1 | no | - writing-quality — skipped-by-dispatch: only dependency manifest and lockfile changed; no prose - test-trimming — skipped-by-dispatch: no tests changed - project-docs — skipped-by-dispatch: no documentation changed - use-effect — skipped-by-dispatch: no React code or Effects changed; only commander dependency versions - react — skipped-by-dispatch: no React components changed; only commander dependency versions
🚀 1
jercik merged commit 956d007533 into main 2026-10-21 13:50:27 +00:00
jercik deleted branch fix/commander-15 2026-10-21 13:50:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/fta-check!4
No description provided.