j4k-oss/worktree-add
Watch
2
0
Fork
You've already forked worktree-add
 0
Code Issues Pull requests Releases 5 Packages 1 Activity Actions

chore: align with j4k-align 17.17.1 #19

Merged
jercik merged 1 commit from chore/align-17-17-1 into main 2026-11-04 07:07:13 +00:00
Conversation 2 Commits 1 Files changed 5 +118 -11
jercik commented 2026-11-04 06:48:13 +00:00
Owner

Adds align 17.17's baked-Node guard before every actions/setup-node step in the Forgejo workflows. A job now stops with an error, instead of downloading Node from GitHub, when its image does not bake the version in .node-version (26.13.0).

The same repair syncs align's other managed files since 17.15.4: a readable PR-field parser in the commit-msg workflow, a scripts/check-msg.sh rejection message that lists the allowed types, and comment fixes in the workflows.

With the workflows current, align's audit of this repository passes clean. Align had refused the typed-lint conversion because of the drifted workflows, and the tsconfig drift and typecheck script findings that came with that refusal no longer appear.

Adds align 17.17's baked-Node guard before every `actions/setup-node` step in the Forgejo workflows. A job now stops with an error, instead of downloading Node from GitHub, when its image does not bake the version in `.node-version` (26.13.0). The same repair syncs align's other managed files since 17.15.4: a readable PR-field parser in the commit-msg workflow, a `scripts/check-msg.sh` rejection message that lists the allowed types, and comment fixes in the workflows. With the workflows current, align's audit of this repository passes clean. Align had refused the typed-lint conversion because of the drifted workflows, and the `tsconfig` drift and `typecheck` script findings that came with that refusal no longer appear.
chore: align with j4k-align 17.17.1
All checks were successful
Checks / reuse (pull_request) Has been skipped
Details
commit-msg / same-repo-pr (pull_request) Has been skipped
Details
commit-msg / commitlint (pull_request) Successful in 9s
Details
Checks / quality-checks (pull_request) Successful in 43s
Details
Checks / qc-result (pull_request) Has been skipped
Details
Review / Review (pull_request_target) Successful in 17m49s
Details
4280c8c4dd
forgejo-actions commented 2026-11-04 07:06:07 +00:00

Review 01M6JN1X6EAS1HHY1S76YVN48R — head 4280c8c4dd160e184c7b524d45cb95e05db664db

Review — j4k-oss/worktree-add @ e7369add4c

Scope: diff against base tree 7740819067ae
Review finished: 6 succeeded, 0 failed, 4 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

  • general-bug (whole/default): no-claims
  • writing-quality (whole/default): no-claims
  • restated-sets (whole/default): no-claims
  • unix-cli (whole/default): no-claims
  • module-design (whole/default): no-claims
  • aposd-plain (whole/default): claims-emitted
  • test-trimming: skipped-by-dispatch — no tests changed
  • project-docs: skipped-by-dispatch — no project documentation changed
  • use-effect: skipped-by-dispatch — no React code; only CI workflows and a shell script changed
  • react: skipped-by-dispatch — no React components; only CI workflows and a shell script changed

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (0)
  • duplicate-of (0)
  • unadjudicated (2)
    • 01M6JNQBRR7E3BMNNNEMRPAJPY medium — The 30-line baked-Node guard is pasted verbatim into three workflows instead of living in one place
    • 01M6JNQVN9907FQRGFG68MEBXR low — The baked-Node guard reads its own copy of the Node pin path instead of the input setup-node actually uses

Coverage

Coverage pass: 01M6JN1X6KQXV50WNJMP00BQNP
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens part arm unit status runs loss
general-bug whole default no-claims 1 no
writing-quality whole default no-claims 1 no
restated-sets whole default no-claims 1 no
unix-cli whole default no-claims 1 no
module-design whole default no-claims 1 no
aposd-plain whole default claims-emitted 1 no
  • test-trimming — skipped-by-dispatch: no tests changed
  • project-docs — skipped-by-dispatch: no project documentation changed
  • use-effect — skipped-by-dispatch: no React code; only CI workflows and a shell script changed
  • react — skipped-by-dispatch: no React components; only CI workflows and a shell script changed
<!-- review:summary --> **Review** `01M6JN1X6EAS1HHY1S76YVN48R` — head `4280c8c4dd160e184c7b524d45cb95e05db664db` # Review — j4k-oss/worktree-add @ e7369add4c93 Scope: diff against base tree `7740819067ae` Review finished: 6 succeeded, 0 failed, 4 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): no-claims - restated-sets (whole/default): no-claims - unix-cli (whole/default): no-claims - module-design (whole/default): no-claims - aposd-plain (whole/default): claims-emitted - test-trimming: skipped-by-dispatch — no tests changed - project-docs: skipped-by-dispatch — no project documentation changed - use-effect: skipped-by-dispatch — no React code; only CI workflows and a shell script changed - react: skipped-by-dispatch — no React components; only CI workflows and a shell script changed ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (2) - `01M6JNQBRR7E3BMNNNEMRPAJPY` medium — The 30-line baked-Node guard is pasted verbatim into three workflows instead of living in one place - `01M6JNQVN9907FQRGFG68MEBXR` low — The baked-Node guard reads its own copy of the Node pin path instead of the input `setup-node` actually uses ## Coverage Coverage pass: 01M6JN1X6KQXV50WNJMP00BQNP Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | restated-sets | whole | default | no-claims | 1 | no | | unix-cli | whole | default | no-claims | 1 | no | | module-design | whole | default | no-claims | 1 | no | | aposd-plain | whole | default | claims-emitted | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - project-docs — skipped-by-dispatch: no project documentation changed - use-effect — skipped-by-dispatch: no React code; only CI workflows and a shell script changed - react — skipped-by-dispatch: no React components; only CI workflows and a shell script changed
🚀 1
jercik commented 2026-11-04 07:06:57 +00:00
Author
Owner

Replying to comment #230743

Both unadjudicated claims repeat ones settled in this rollout. Neither is a defect in this PR.

  • 01M6JNQBRR7E3BMNNNEMRPAJPY (medium, the baked-Node guard repeated in three workflows): these workflows are j4k-align --fix output. Each align template emits the step with {{templateScript "baked-node-check" 10}}, whose single source is BAKED_NODE_CHECK_SCRIPT in src/template-scripts/baked-node-check-script.ts (j4k/align at 7a2b6118). A hand edit to one copy shows up as drift in the next align audit. Settled the same way at j4k/sorcery-rules-skill#28 (comment).
  • 01M6JNQVN9907FQRGFG68MEBXR (low, the guard names .node-version separately from setup-node's node-version-file): the align template writes both values side by side, and a local repoint of either would be drift that --fix reverts. Deriving both from one value is a change for j4k/align's template, which I am reporting there. Settled the same way at j4k/sorcery-rules-skill#28 (comment).
> Replying to comment #230743 Both unadjudicated claims repeat ones settled in this rollout. Neither is a defect in this PR. - `01M6JNQBRR7E3BMNNNEMRPAJPY` (medium, the baked-Node guard repeated in three workflows): these workflows are `j4k-align --fix` output. Each align template emits the step with `{{templateScript "baked-node-check" 10}}`, whose single source is `BAKED_NODE_CHECK_SCRIPT` in `src/template-scripts/baked-node-check-script.ts` (j4k/align at `7a2b6118`). A hand edit to one copy shows up as drift in the next align audit. Settled the same way at https://code.j4k.dev/j4k/sorcery-rules-skill/pulls/28#issuecomment-230698. - `01M6JNQVN9907FQRGFG68MEBXR` (low, the guard names `.node-version` separately from setup-node's `node-version-file`): the align template writes both values side by side, and a local repoint of either would be drift that `--fix` reverts. Deriving both from one value is a change for j4k/align's template, which I am reporting there. Settled the same way at https://code.j4k.dev/j4k/sorcery-rules-skill/pulls/28#issuecomment-230700.
jercik merged commit bfcb62f7c1 into main 2026-11-04 07:07:13 +00:00
jercik deleted branch chore/align-17-17-1 2026-11-04 07:07:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/worktree-add!19
No description provided.