docs: reference canonical ADR status meanings #107

jercik · 2026-10-03T21:39:57Z

jercik commented

2026-10-03 21:39:57 +00:00

Removes the repeated ADR status meanings identified in #98, preserving its merged binding rules, current-record guidance and whole-ADR verification obligations.

Removes the repeated ADR status meanings identified in [#98](https://code.j4k.dev/j4k-oss/agent-skills/pulls/98), preserving its merged binding rules, current-record guidance and whole-ADR verification obligations.

jercik added 1 commit

2026-10-03 21:39:57 +00:00

docs: reference canonical ADR status meanings

commit-msg / commitlint (pull_request) Successful in 28s

Details

Node tests / node:test (pull_request) Successful in 4m26s

Details

Review / Review (pull_request_target) Has been cancelled

Details

4c0f5a833d

forgejo-actions commented

2026-10-03 21:45:17 +00:00

Review 01M41X6M6218G2CB20VSD1NDXN — head f400728b71f1afb6aca80748e541e620d30dc46d

Review — j4k-oss/agent-skills @ `01290ee2bd`

Scope: diff against base tree 2034125557e6
Status: dispatched — coverage complete (4/4 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v3",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

general-bug (whole/default): no-claims
writing-quality (whole/default): no-claims
test-trimming (whole/default): no-claims
restated-sets (whole/default): no-claims

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M41X6M79EYKSFVYN9253YEHT
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	no-claims	1	no
test-trimming	whole	default	no-claims	1	no
restated-sets	whole	default	no-claims	1	no

**Review** `01M41X6M6218G2CB20VSD1NDXN` — head `f400728b71f1afb6aca80748e541e620d30dc46d` # Review — j4k-oss/agent-skills @ 01290ee2bdd5 Scope: diff against base tree `2034125557e6` Status: dispatched — coverage complete (4/4 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v3", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): no-claims - test-trimming (whole/default): no-claims - restated-sets (whole/default): no-claims ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M41X6M79EYKSFVYN9253YEHT Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | test-trimming | whole | default | no-claims | 1 | no | | restated-sets | whole | default | no-claims | 1 | no |

🚀 1

forgejo-actions reviewed

2026-10-03 21:45:18 +00:00

skills/project-docs/SKILL.md Outdated

					
				@ -58,3 +58,3 @@

				- **Use the glossary's canonical terms** in everything you produce — plans, code, commit messages. When the user's wording conflicts with a defined term, flag the mismatch instead of silently adopting either side.

				- **Don't re-litigate recorded ADRs.** A status-less ADR counts as accepted; only an ADR marked `proposed` is still open, and a `deprecated` or `superseded` one no longer binds — its successor, where one exists, governs instead. If the plan contradicts a binding ADR, name it ("this conflicts with ADR-0007") and either adjust the plan or supersede the ADR — never silently override a recorded decision.

				- **Don't re-litigate recorded ADRs.** Apply the status meanings in "ADR format". A status-less ADR counts as accepted; for a deprecated or superseded ADR, its successor, where one exists, governs instead. If the plan contradicts a binding ADR, name it ("this conflicts with ADR-0007") and either adjust the plan or supersede the ADR — never silently override a recorded decision.

high — Binding guidance repeats the nonbinding ADR status set

I read the full project-docs skill and its “ADR format” section. The Status frontmatter entry in skills/project-docs/SKILL.md defines the values as proposed | accepted | deprecated | superseded by ADR-NNNN and says “proposed is still open, and deprecated and superseded no longer bind.” The changed binding guidance then repeats the two nonbinding status members as “deprecated or superseded.” The copy currently agrees with the definition, but a later status change could leave this instruction silently stale. This is ongoing guidance, not a dated record, a table of contents, or an example; its reader can use the cited section in the same file. Keep the status-less default here and word the successor rule without naming the status members, for example: “A status-less ADR counts as accepted; when an ADR's status makes it nonbinding, its successor, where one exists, governs instead.” The decisive evidence is the quoted Status entry and the changed sentence; I found no separate status schema or parser in the snapshot.

lens restated-sets · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M41VEV4W56TQXSR0HKAGQT62 of review 01M41VBCK5R2QYB9FGSY320PK9

**high** — Binding guidance repeats the nonbinding ADR status set > I read the full project-docs skill and its “ADR format” section. The Status frontmatter entry in skills/project-docs/SKILL.md defines the values as `proposed | accepted | deprecated | superseded by ADR-NNNN` and says “`proposed` is still open, and `deprecated` and `superseded` no longer bind.” The changed binding guidance then repeats the two nonbinding status members as “deprecated or superseded.” The copy currently agrees with the definition, but a later status change could leave this instruction silently stale. This is ongoing guidance, not a dated record, a table of contents, or an example; its reader can use the cited section in the same file. Keep the status-less default here and word the successor rule without naming the status members, for example: “A status-less ADR counts as accepted; when an ADR's status makes it nonbinding, its successor, where one exists, governs instead.” The decisive evidence is the quoted Status entry and the changed sentence; I found no separate status schema or parser in the snapshot. lens `restated-sets` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M41VEV4W56TQXSR0HKAGQT62` of review `01M41VBCK5R2QYB9FGSY320PK9`

👎 1

The successor condition is a purposeful partial set for a distinct action, preserved from the default source at e7d02b5: deprecated or superseded records use their successor where one exists. The canonical format now owns status meanings; Loading refers to it instead of repeating the complete status set. Replacing this branch with every nonbinding status would broaden the successor condition rather than only remove the duplicate definition. The authorized repair explicitly preserves purposeful partial sets and existing successor behavior. A fresh independent review confirmed this is not a defect in the bounded repair; no source change is made.

The successor condition is a purposeful partial set for a distinct action, preserved from the default source at e7d02b5: deprecated or superseded records use their successor where one exists. The canonical format now owns status meanings; Loading refers to it instead of repeating the complete status set. Replacing this branch with every nonbinding status would broaden the successor condition rather than only remove the duplicate definition. The authorized repair explicitly preserves purposeful partial sets and existing successor behavior. A fresh independent review confirmed this is not a defect in the bounded repair; no source change is made.

superseded by review 01M41X6M6218G2CB20VSD1NDXN for head f400728b71f1afb6aca80748e541e620d30dc46d

superseded by review `01M41X6M6218G2CB20VSD1NDXN` for head `f400728b71f1afb6aca80748e541e620d30dc46d`

🚀 1