fix(skills): exit code verification should check the README pointer #111
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/io3-verify-readme-pointer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Addresses the IO3 verification clarification in #97 by checking its existing README pointer and retry-guidance requirement. This stacks on #97 and must merge after it.
Review
01M422NY2KB9QFRBFA42W5JF6Q— head4f6c27dd22f7fdc91eda7022449f0ed5750feb44Review — j4k-oss/agent-skills @
b178c9c55eScope: diff against base tree
df400b9b0b87Status: dispatched — coverage complete (4/4 slots terminal)
Facts: current review-wide projection
Computed under:
Findings (1)
low — The README check repeats the exit-code rule without adding a verification method
01M422RJ2QRMG5SBN9XXZXW97Pskills/verify-unixy-cli/references/io3-exit-codes.md(snippet)Other claims
Coverage
Coverage pass: 01M422NY4B2PSC3TF7W5ZR4CB8
Accounting: complete
Slot health: healthy
@ -14,3 +14,3 @@**Multi-state verdicts**: When the tool's verdict has more than two states, give each state its own documented exit code instead of making callers parse output. `grep` is the classic form — `0` match, `1` no match, `2` error — and `gh pr checks` the modern one: `0` passing, `1` failing, a documented `8` while checks are pending, so a script can wait on pending without scraping prose. Keep `0` for the good state, give each remaining state — errors included — its own nonzero code, and document every code in `--help`. When one table in the code maps states to codes, render help's list from that table. The README points at `--help` for the codes and keeps what help can't show, such as which codes are safe to retry. Avoid codes with reserved meanings: `126`–`127` (not executable / not found) and `128+n` (killed by signal `n`).**How to verify**: Search for `process.exit()` and `process.exitCode` usage. Ensure success returns 0 and errors return non-zero. Test: run CLI without required args and verify exit code is non-zero. If the tool's domain has a more-than-binary verdict, check that distinct states get distinct exit codes and that `--help` documents them, rendered from the code's state-to-code table when one exists.**How to verify**: Search for `process.exit()` and `process.exitCode` usage. Ensure success returns 0 and errors return non-zero. Test: run CLI without required args and verify exit code is non-zero. If the tool's domain has a more-than-binary verdict, check that distinct states get distinct exit codes and that `--help` documents them, rendered from the code's state-to-code table when one exists. Check that the README points at `--help` for the codes and keeps any retry guidance that help cannot show.low — The README check repeats the exit-code rule without adding a verification method
lens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M422RJ2QRMG5SBN9XXZXW97Pof review01M422NY2KB9QFRBFA42W5JF6QCandidate withdrawn: verify-unixy-cli requires reading each reference in full (line 22) and verifying every applicable rule with evidence (lines 79–81). IO3 already includes the README pointer and retry-guidance requirement. This candidate repeats that rule without a distinct verification operation; the source finding's sole-checklist premise is unsupported. The PR will close without merging.
Pull request closed