j4k-oss/agent-skills
Watch
1
0
Fork
You've already forked agent-skills
 0
Code Issues 6 Pull requests Releases Packages Activity Actions

fix: doc drift fix-direction section should not restate the default direction #131

Merged
jercik merged 1 commit from fix/doc-drift-fix-direction-duplication into main 2026-10-09 03:14:26 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
jercik commented 2026-10-08 18:07:51 +00:00
Owner
Copy link

Removes the two sentences at the start of "Fix direction and missing features" that repeat the opening paragraph (docs follow the code by default) and the code-drift definition (change code only when the doc is the source of truth). The section keeps the missing-feature case, which nothing else covers.

Follow-up to an unadjudicated review claim on #129. The text predates #129 and is independent of it.

🤖 Generated with Claude Code

Removes the two sentences at the start of "Fix direction and missing features" that repeat the opening paragraph (docs follow the code by default) and the `code-drift` definition (change code only when the doc is the source of truth). The section keeps the missing-feature case, which nothing else covers. Follow-up to an unadjudicated review claim on [#129](https://code.j4k.dev/j4k-oss/agent-skills/pulls/129#issuecomment-144471). The text predates #129 and is independent of it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix: doc drift fix-direction section should not restate the default direction
All checks were successful
commit-msg / commitlint (pull_request) Successful in 25s
Details
Review / Review (pull_request_target) Successful in 1m21s
Details
Node tests / node:test (pull_request) Successful in 2m55s
Details
9a9366d025
 
The opening paragraph and the code-drift category already state both rules.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
forgejo-actions commented 2026-10-08 18:09:13 +00:00
Copy link

Review 01M4EB6NABDKDKPX2X8P8J2S97 — head 9a9366d025bc905f1caeba543863193d8f350655

Review — j4k-oss/agent-skills @ b0587ed3cf

Scope: diff against base tree f3c2243da4c8
Status: dispatched — coverage complete (3/3 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

  • general-bug (whole/default): no-claims
  • writing-quality (whole/default): no-claims
  • project-docs (whole/default): no-claims
  • test-trimming: skipped-by-dispatch — no tests changed
  • restated-sets: skipped-by-dispatch — single sentence edit in a skill doc; no enumerated sets restated

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (0)
  • duplicate-of (0)
  • unadjudicated (0)

Coverage

Coverage pass: 01M4EB7K765HMZQWC8B6DX9TA6
Accounting: complete
Slot health: healthy

lens part arm unit status runs loss
general-bug whole default no-claims 1 no
writing-quality whole default no-claims 1 no
project-docs whole default no-claims 1 no
  • test-trimming — skipped-by-dispatch: no tests changed
  • restated-sets — skipped-by-dispatch: single sentence edit in a skill doc; no enumerated sets restated
<!-- review:summary --> **Review** `01M4EB6NABDKDKPX2X8P8J2S97` — head `9a9366d025bc905f1caeba543863193d8f350655` # Review — j4k-oss/agent-skills @ b0587ed3cfdd Scope: diff against base tree `f3c2243da4c8` Status: dispatched — coverage complete (3/3 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): no-claims - project-docs (whole/default): no-claims - test-trimming: skipped-by-dispatch — no tests changed - restated-sets: skipped-by-dispatch — single sentence edit in a skill doc; no enumerated sets restated ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M4EB7K765HMZQWC8B6DX9TA6 Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | project-docs | whole | default | no-claims | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: single sentence edit in a skill doc; no enumerated sets restated
🚀 1
jercik merged commit 3dae0c1acc into main 2026-10-09 03:14:26 +00:00
jercik deleted branch fix/doc-drift-fix-direction-duplication 2026-10-09 03:14:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/agent-skills!131
No description provided.