fix: move-codex-session skill should state which processes block a move #134

Merged

jercik merged 1 commit from fix/move-codex-session-skill-refusals into main 2026-10-09 21:04:12 +00:00

Conversation 1 Commits 1 Files changed 1 +5 -1

jercik commented 2026-10-09 19:59:02 +00:00

Owner

Copy link

Follow-up to #132 from two of its review findings (incomplete refusal list, process-tree wording).

The skill listed some of the script's refusals as if the list were complete. It also said the destination home may be open anywhere in the invoking process tree, but the script allows only itself and its ancestors there, so a process the invoking Codex started still blocks the move.

The skill now states the two home-activity requirements a caller can act on before running the script, and leaves every other refusal to the script's error message. The refusal list and the process-tree wording predate #132.

Follow-up to #132 from two of its review findings ([incomplete refusal list](https://code.j4k.dev/j4k-oss/agent-skills/pulls/132#issuecomment-150304), [process-tree wording](https://code.j4k.dev/j4k-oss/agent-skills/pulls/132#issuecomment-150306)). The skill listed some of the script's refusals as if the list were complete. It also said the destination home may be open anywhere in the invoking process tree, but the script allows only itself and its ancestors there, so a process the invoking Codex started still blocks the move. The skill now states the two home-activity requirements a caller can act on before running the script, and leaves every other refusal to the script's error message. The refusal list and the process-tree wording predate #132.

jercik added 1 commit 2026-10-09 19:59:02 +00:00

fix: move-codex-session skill should state which processes block a move ... 226a1ae2af

The skill listed some of the script's refusals as if the list were complete,
and said the destination home may be open anywhere in the invoking process
tree. The script allows only itself and its ancestors there. The skill now
states the two home-activity prerequisites the caller can act on and points
to the script's error for every other blocker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jercik referenced this pull request 2026-10-09 20:01:09 +00:00

fix: move-codex-session should handle Codex 0.160.1 and large native homes #132

jercik referenced this pull request 2026-10-09 20:01:13 +00:00

fix: move-codex-session should handle Codex 0.160.1 and large native homes #132

forgejo-actions commented 2026-10-09 20:02:23 +00:00

Copy link

Review 01M4H3YWH68W76A0XM92XBCS33 — head c36631d9c2108d7ab07043e1f2946f15b8906d17

Review — j4k-oss/agent-skills @ fefbeff71e

Scope: diff against base tree 40154724b696
Status: dispatched — coverage complete (3/3 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

• general-bug (whole/default): claims-emitted
• writing-quality (whole/default): no-claims
• project-docs (whole/default): no-claims
• test-trimming: skipped-by-dispatch — no tests changed
• restated-sets: skipped-by-dispatch — no enumerated sets or lists restated across files in this documentation-only change

Other claims

• grounding-pending (0)
• ungrounded (0)
• rejected (1)
  • 01M4H429X9XV96F56BXDBQ5EMZ low — The process-availability instructions omit the script's own lock helpers
• duplicate-of (0)
• unadjudicated (0)

Coverage

Coverage pass: 01M4H3ZD1M7D4XR9AJDDMYKXJT
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	claims-emitted	1	no
writing-quality	whole	default	no-claims	1	no
project-docs	whole	default	no-claims	1	no

• test-trimming — skipped-by-dispatch: no tests changed
• restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across files in this documentation-only change

<!-- review:summary --> **Review** `01M4H3YWH68W76A0XM92XBCS33` — head `c36631d9c2108d7ab07043e1f2946f15b8906d17` # Review — j4k-oss/agent-skills @ fefbeff71e54 Scope: diff against base tree `40154724b696` Status: dispatched — coverage complete (3/3 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): claims-emitted - writing-quality (whole/default): no-claims - project-docs (whole/default): no-claims - test-trimming: skipped-by-dispatch — no tests changed - restated-sets: skipped-by-dispatch — no enumerated sets or lists restated across files in this documentation-only change ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M4H429X9XV96F56BXDBQ5EMZ` low — The process-availability instructions omit the script's own lock helpers - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M4H3ZD1M7D4XR9AJDDMYKXJT Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | claims-emitted | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | project-docs | whole | default | no-claims | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across files in this documentation-only change

🚀 1

jercik changed target branch from fix/move-codex-session-codex-0160 to main 2026-10-09 20:58:06 +00:00

jercik force-pushed fix/move-codex-session-skill-refusals from 226a1ae2af to c36631d9c2 2026-10-09 20:58:45 +00:00 Compare

jercik merged commit 1a85c77277 into main 2026-10-09 21:04:12 +00:00

jercik deleted branch fix/move-codex-session-skill-refusals 2026-10-09 21:04:12 +00:00

jercik referenced this pull request from a commit 2026-10-09 21:04:14 +00:00

fix: `move-codex-session` skill should state which processes block a move (#134)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

j4k-oss/agent-skills!134

No description provided.