test: make the `move-codex-session` precision test fire its trigger once #136

Merged

jercik merged 1 commit from test/move-codex-session-precision-trigger into main

2026-10-09 21:03:44 +00:00

jercik commented

2026-10-09 19:59:05 +00:00

Owner

Follow-up to #132 from its review (finding).

The precision test's trigger fired for both inserted threads and moved 9007199254740993 to 9007199254740991. A double represents the second value exactly, so a snapshot that encoded integers through Number still saw the change, and the test passed. The trigger now fires only for the root thread, leaving 9007199254740992, which a double cannot tell apart from the original.

With encodeSqliteValue changed to return Number(value).toString(), the old test passes and the new one fails because the move exits 0. Both pass against the real encoder.

Follow-up to #132 from its review ([finding](https://code.j4k.dev/j4k-oss/agent-skills/pulls/132#issuecomment-150308)). The precision test's trigger fired for both inserted threads and moved 9007199254740993 to 9007199254740991. A double represents the second value exactly, so a snapshot that encoded integers through `Number` still saw the change, and the test passed. The trigger now fires only for the root thread, leaving 9007199254740992, which a double cannot tell apart from the original. With `encodeSqliteValue` changed to return `Number(value).toString()`, the old test passes and the new one fails because the move exits 0. Both pass against the real encoder.

jercik added 1 commit

2026-10-09 19:59:05 +00:00

test: make the move-codex-session precision test fire its trigger once

commit-msg / commitlint (pull_request) Successful in 16s

Details

Review / Review (pull_request_target) Successful in 1m38s

Details

Node tests / node:test (pull_request) Successful in 3m9s

Details

9dfed55090

The trigger ran for both inserted threads, moving the integer to a value a
double can represent, so a snapshot that rounded integers through Number
still passed. Firing it for one thread leaves a change only exact integer
encoding detects.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

forgejo-actions commented

2026-10-09 20:00:41 +00:00

Review 01M4H3Z15ZVGY6HP0X8N0RPG0B — head a63a687689b5aa837847e95349426d0dee28af26

Review — j4k-oss/agent-skills @ `c55fff69d7`

Scope: diff against base tree 40154724b696
Status: dispatched — coverage complete (5/5 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

general-bug (whole/default): no-claims
writing-quality (whole/default): no-claims
test-trimming (whole/default): no-claims
restated-sets (whole/default): no-claims
project-docs (whole/default): no-claims

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M4H3Z1A055JP7WH46F9C3FAR
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	no-claims	1	no
test-trimming	whole	default	no-claims	1	no
restated-sets	whole	default	no-claims	1	no
project-docs	whole	default	no-claims	1	no

**Review** `01M4H3Z15ZVGY6HP0X8N0RPG0B` — head `a63a687689b5aa837847e95349426d0dee28af26` # Review — j4k-oss/agent-skills @ c55fff69d731 Scope: diff against base tree `40154724b696` Status: dispatched — coverage complete (5/5 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): no-claims - test-trimming (whole/default): no-claims - restated-sets (whole/default): no-claims - project-docs (whole/default): no-claims ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M4H3Z1A055JP7WH46F9C3FAR Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | test-trimming | whole | default | no-claims | 1 | no | | restated-sets | whole | default | no-claims | 1 | no | | project-docs | whole | default | no-claims | 1 | no |

🚀 1

jercik referenced this pull request

2026-10-09 20:01:22 +00:00

fix: move-codex-session should handle Codex 0.160.1 and large native homes #132

jercik referenced this pull request

2026-10-09 20:01:33 +00:00

fix: move-codex-session rollback should keep destination history rows it never copied #133

jercik changed target branch from fix/move-codex-session-codex-0160 to main

2026-10-09 20:58:06 +00:00

jercik force-pushed test/move-codex-session-precision-trigger from 9dfed55090

commit-msg / commitlint (pull_request) Successful in 16s

Details