test: check every moved move-codex-session table in the index-publication rollback test #137

Merged

jercik merged 1 commit from test/move-codex-session-rollback-assertions into main 2026-10-09 21:03:52 +00:00

Conversation 1 Commits 1 Files changed 1 +10

jercik commented 2026-10-09 20:07:59 +00:00

Owner

Copy link

Follow-up to #135 from its review (summary finding 01M4H41HT6VPDJWAQEGK3SWH9H; its anchor is outside #135's diff, so it has no inline thread).

The index-publication rollback test checked one table per destination database. With the destination rollback's thread_spawn_edges or thread_dynamic_tools delete removed, it still passed. Another test caught both through its retry, so the suite had coverage, but this test did not. It now also checks the destination's sections, spawn edges, dynamic tools, history items, projection state and goal deferrals, and that the destination's own settings row survives. Both mutants now fail it.

It touches different lines than #135's rename, so the two merge in either order.

Follow-up to #135 from its review (summary finding `01M4H41HT6VPDJWAQEGK3SWH9H`; its anchor is outside #135's diff, so it has no inline thread). The index-publication rollback test checked one table per destination database. With the destination rollback's `thread_spawn_edges` or `thread_dynamic_tools` delete removed, it still passed. Another test caught both through its retry, so the suite had coverage, but this test did not. It now also checks the destination's sections, spawn edges, dynamic tools, history items, projection state and goal deferrals, and that the destination's own `settings` row survives. Both mutants now fail it. It touches different lines than #135's rename, so the two merge in either order.

jercik added 1 commit 2026-10-09 20:07:59 +00:00

test: check every moved move-codex-session table in the index-publication rollback test ... 654cc9e599

The test checked one table per destination database, so a rollback that left
spawn edges or dynamic tools behind still passed it. It now checks every
table the fixture moves, and that the destination's own state row survives.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jercik referenced this pull request 2026-10-09 20:08:09 +00:00

test: name the move-codex-session rollback test for its trigger and outcome #135

forgejo-actions commented 2026-10-09 20:09:03 +00:00

Copy link

Review 01M4H4FA9KRSF8SSNNAR8DNMA0 — head 3921eff3b048ae07a7ac45ff79ce098d82375a93

Review — j4k-oss/agent-skills @ 93eb57b4f7

Scope: diff against base tree 40154724b696
Status: dispatched — coverage complete (2/2 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

• general-bug (whole/default): no-claims
• test-trimming (whole/default): no-claims
• writing-quality: skipped-by-dispatch — only test assertions added; no prose changed
• restated-sets: skipped-by-dispatch — no enumerated set restated across files; single test file changed
• project-docs: skipped-by-dispatch — no documentation changed

Other claims

• grounding-pending (0)
• ungrounded (0)
• rejected (0)
• duplicate-of (0)
• unadjudicated (0)

Coverage

Coverage pass: 01M4H4FQSXWC2HGF29Z4E02JJV
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
test-trimming	whole	default	no-claims	1	no

• writing-quality — skipped-by-dispatch: only test assertions added; no prose changed
• restated-sets — skipped-by-dispatch: no enumerated set restated across files; single test file changed
• project-docs — skipped-by-dispatch: no documentation changed

<!-- review:summary --> **Review** `01M4H4FA9KRSF8SSNNAR8DNMA0` — head `3921eff3b048ae07a7ac45ff79ce098d82375a93` # Review — j4k-oss/agent-skills @ 93eb57b4f7c6 Scope: diff against base tree `40154724b696` Status: dispatched — coverage complete (2/2 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - test-trimming (whole/default): no-claims - writing-quality: skipped-by-dispatch — only test assertions added; no prose changed - restated-sets: skipped-by-dispatch — no enumerated set restated across files; single test file changed - project-docs: skipped-by-dispatch — no documentation changed ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M4H4FQSXWC2HGF29Z4E02JJV Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | test-trimming | whole | default | no-claims | 1 | no | - writing-quality — skipped-by-dispatch: only test assertions added; no prose changed - restated-sets — skipped-by-dispatch: no enumerated set restated across files; single test file changed - project-docs — skipped-by-dispatch: no documentation changed

🚀 1

jercik changed target branch from fix/move-codex-session-codex-0160 to main 2026-10-09 20:58:05 +00:00

jercik force-pushed test/move-codex-session-rollback-assertions from 654cc9e599 to 3921eff3b0 2026-10-09 20:58:55 +00:00 Compare

jercik merged commit 53e04a123c into main 2026-10-09 21:03:52 +00:00

jercik deleted branch test/move-codex-session-rollback-assertions 2026-10-09 21:03:52 +00:00

jercik referenced this pull request from a commit 2026-10-09 21:03:54 +00:00

test: check every moved `move-codex-session` table in the index-publication rollback test (#137)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

j4k-oss/agent-skills!137

No description provided.