feat: remove the create-prs-with-gh skill #32
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/delete-create-prs-with-gh"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Estate-triage decision: the skill duplicates the corpus rule that already teaches the
ghquoting mechanics (single-quoted heredoc into--body-file -), and its content guidance now lives inhuman-facing-writing-style's Pull requests section. Nothing else references it. Supersedes #31.Approach review: Deleting the skill outright is the right shape for this change, and I found no materially better alternative.
What I checked in the working tree:
skills/create-prs-with-gh/directory is gone, which is allaxskillsneeds: the source's selectable names are the directory names, andaxskills syncprunes its managed copies in~/.claude/skills, so a removed skill disappears on the next sync. There is no alias or tombstone mechanism to maintain, so a redirect stub would only be a name that keeps occupying the picker..git) for the skill name,gh pr create, andbody-filereturns no hits, andscripts/holds only a test reporter — there is no manifest or index that enumerates skills and would need a matching edit.skills/human-facing-writing-style/SKILL.md:267carries the## Pull requestssection (titles, body shape, what gets cut), and that skill'sdescriptionalready triggers on "draft a PR description", so the routing the removed skill provided for content questions is preserved.One thing I could not verify from this checkout, flagged rather than objected to: the claim that the
ghquoting mechanics (single-quoted heredoc into--body-file -) live in a corpus rule. This repository ships skills only and vendors norules/tree, so the corpus is out of reach here. The renderedAGENTS.mdcovers shell-injection safety in general terms but does not teach the--body-file -heredoc form specifically. If the corpus rule is in fact the only remaining home for that mechanic, it is worth confirming it is in the always-on selection before this merges — moving a mechanical trap from an opt-in skill to an always-delivered rule is an improvement, but only once the rule actually carries it.Approach review by Claude Code Opus (opus)
Summary: Clean deletion; 1 informational note.
Verified against the working tree:
skills/create-prs-with-gh/is fully removed (the singleSKILL.mdwas its only file); no orphan directory remains.grep -rn create-prs-with-ghover the tree (excluding.git) returns nothing, so the PR's "nothing else references it" claim holds. The repo has no skill manifest or index —README.mddocuments the layout without enumerating skills, and the.forgejoworkflows don't list skill names — so nothing else needs updating.skills/human-facing-writing-style/SKILL.md:267carries the "Pull requests" section (titles, body, what gets cut), and its frontmatter description already triggers on "write the PR title or body" and "draft a PR description", so the discovery path for PR-writing guidance survives the removal.The one thing I could not verify from this repository is the shell-quoting half of the claim; see the inline note.
Code review by Claude Code Opus (opus)
@ -9,4 +0,0 @@# Reference**Don't put Markdown in a double-quoted `--body` string.** The shell expands backticks and `$...` before `gh` sees it, mangling code blocks and variable references.ℹ️ Info: The content guidance clearly survives in
human-facing-writing-style, but I could not confirm the quoting mechanics do. This repo's renderedAGENTS.md"Safe Command Execution" rule covers command arrays and variable interpolation intosh -c/eval/sshstrings — it never mentionsgh,--body-file -, or the single-quoted heredoc, and the failure mode here is different (the shell expanding backticks and$...inside a double-quoted literal, with no variable involved). No other file in the tree mentionsgh pr createor--body-file. If the corpus rule that teaches this is one that simply isn't selected for this repository, the claim stands and nothing needs doing; if the corpus only carries the interpolation rule quoted inAGENTS.md, this specific trap is being dropped rather than deduplicated. Worth confirming in the corpus before merge. Note also that this repo is on Forgejo andAGENTS.mddirects forge-side mutations tofgj, which makes agh-specific skill a weaker fit here regardless.Adjudication — 41652 (Info, the only finding; both surviving slots converged on it): confirmed in the corpus, no change needed. The quoting mechanics survive verbatim in
j4k/align:rules/ai-coding-workflow/creating-prs.md— its GitHub half is the exactgh pr create --body-file - <<'EOF'single-quoted-heredoc pattern this skill taught (lines 7–12), and it adds thefgjequivalent thisgh-only skill lacked. The reviewers couldn't see it because this repo vendors no rules tree:ai-coding-workflowis one of the twoGLOBAL_SHARED_CATEGORIES(src/agent-instructions/global-targets.ts:28), so the rule renders into all five workstation globals and reaches every agent session on the machine without any skill invocation — always-on, not opt-in. The deletion deduplicates; it drops nothing. Resolving.(The three failed generator slots are the known fleet-wide capability-exchange regression — sixth consecutive failure for
code-smart-2, second for the approach slots — service-side, unrelated to this PR.)