chore(agent-browser): re-sync the vendored stub with the 0.33.2 CLI #43
Loading…
Reference in a new issue
No description provided.
Delete branch "align/agent-browser"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The central copy drifted from the discovery stub the CLI ships: it was hand-rewrapped at import, and agent-browser 0.33.2 now serves a
derive-clientskill (record a HAR, derive a standalone API client) the enumeration omits. This replaces the file with a byte-for-byte copy of the shipped stub, so future refreshes are plain diff-checkable copies instead of merges.Approach review: The approach looks good.
Approach review by Codex GPT-5.6 SOL (gpt-5.6-sol)
Summary: No actionable issues found; 1 informational note.
The PR's central claim checks out. I downloaded
agent-browser@0.33.2from npm and comparedpackage/skills/agent-browser/SKILL.mdagainst the vendoredskills/agent-browser/SKILL.mdwithcmp: byte-identical. The rewrapping to single-line paragraphs and the addedderive-clientline are both exactly what upstream ships, so future refreshes really do become plain diff-checkable copies.Spot checks:
derive-clientis a real skill in the 0.33.2 tarball (package/skill-data/derive-client/SKILL.md), and the one-line gloss in the enumeration matches its purpose.agentcore,derive-client,dogfood,electron,slack,vercel-sandbox); onlycoreis omitted, which the "Start here" section already handles..forgejo/workflows/node-test.ymlrunsnode:testonly) and.githooks/pre-commitonly runsgit diff --cached --check, so nothing will re-wrap the file and silently break byte parity.Code review by Claude Code Opus (opus)
@ -34,12 +30,12 @@ Load a specialized skill when the task falls outside browser web pages:agent-browser skills get electron # Electron desktop apps (VS Code, Slack, Discord, Figma, ...)agent-browser skills get slack # Slack workspace automationagent-browser skills get dogfood # Exploratory testing / QA / bug huntsagent-browser skills get derive-client # Record a HAR, derive a standalone API client for a siteℹ️ Info: The body now advertises
derive-client, but the frontmatterdescription— which is what the axskills picker shows and what drives skill triggering — still enumerates only Electron, Slack, dogfood/QA, Vercel Sandbox, and AgentCore. An agent that never loads the body won't associate "reverse engineer this site's API" or "record a HAR" with this skill.No action needed here: editing the description would break the byte-for-byte parity with the shipped stub that this PR exists to establish, and the gap is upstream's to close. Flagging only so it's a known tradeoff rather than a surprise.
@ -34,12 +30,12 @@ Load a specialized skill when the task falls outside browser web pages:agent-browser skills get electron # Electron desktop apps (VS Code, Slack, Discord, Figma, ...)agent-browser skills get slack # Slack workspace automationagent-browser skills get dogfood # Exploratory testing / QA / bug huntsagent-browser skills get derive-client # Record a HAR, derive a standalone API client for a siteAcknowledged, no change — and agreed on both halves.
The observation is correct: the frontmatter
descriptionnames the Electron, Slack, dogfood/QA, Vercel Sandbox, and AgentCore use cases but nothing HAR- or API-derivation-shaped, so a picker that never loads the body won't route "record a HAR" here on the new line alone.Deliberately leaving it: parity with the shipped stub is whole-file (your
cmpagainst theagent-browser@0.33.2tarball covered the frontmatter too), so editing the description locally would reintroduce exactly the drift class this PR exists to remove. The right home for the trigger phrase is upstream's owndescription; if they add it, the next refresh picks it up as a plain diff. Meanwhile the description's broad clauses ("extracting data", "any task requiring programmatic web interaction") still catch most derive-client-adjacent asks, so the gap is narrow.