docs(css-text-box-trim): cut guidance the reference file already owns #45
Loading…
Reference in a new issue
No description provided.
Delete branch "align/css-text-box-trim"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Deletions only. The ex-alphabetic paragraph, the button padding-compensation recipe (identical numbers), and the
@supportsguidance all live inreferences/css-text-box-trim.md, which the skill already tells the agent to read on every invocation. The Inputs sentence enumerating constraints to honor goes too: honoring supplied constraints is default behavior. Task steps 3 and 6 keep the items that drive decisions (component, font, writing mode, browser support target, target locales, fallback fonts); framework and codebase constraints drop entirely.Approach review: Deduplicating the skill body against its always-read reference is the right approach here, and the specific deletions check out.
ex alphabeticguidance survives inreferences/css-text-box-trim.md(shorthand example under Syntax, plus the Values entry describing when x-height reads better and the note thatcap alphabetic/ex alphabeticare the practical Latin pairs).padding-block: 0.35rem; padding-inline: 0.75remthenpadding: 0.625rem 0.75rem), and the reference adds the testing caveats the skill copy lacked.@supportssnippet is covered by the reference's Progressive enhancement section, which also explains why to prefer it over JS measurement or magic-number offsets.Taskstep 5 keeps the instruction to use progressive enhancement, so the behavioral cue is not lost with the example.Tasksteps 3 and 6 already name component, font, writing mode, browser support target, and target locales, and the shortened Inputs section now matches the shape used by the other skills in this repo.The
Referencesection gates the read on "before explaining the feature or changing production CSS," which spans every path the removed material mattered for, so the moved-out detail stays reachable. Keeping one minimalcap alphabeticexample inDefault CSSis consistent with theOutputinstruction to give one minimal example, so the file still stands on its own for the common case. No materially better approach.Approach review by Claude Code Opus (opus)
Summary: No actionable issues found. 1 informational note.
Verified every deletion against
skills/css-text-box-trim/references/css-text-box-trim.md, which the skill body still links at line 18:ex alphabeticguidance survives in the reference (Syntax example line 52, Values entry line 97, Latin-script pairing line 100).@supportsprogressive-enhancement guidance survives under "Progressive enhancement" (lines 188-206).padding-block: 0.35rem/padding-inline: 0.75rembefore trimming andpadding: 0.625rem 0.75remafter.The remaining SKILL.md is internally consistent: task step 5 still calls for progressive enhancement and step 3 still covers value selection, both backed by the reference read. The relative link resolves, the frontmatter and heading structure are intact, and nothing else in the repository referenced the removed blocks.
Code review by Claude Code Opus (opus)
@ -10,3 +10,3 @@# InputsUse the surrounding user request as the scope. Honor any supplied component, font, locale, browser support target, framework, and codebase constraints.Use the surrounding user request as the scope.ℹ️ Info: The shortened sentence matches the convention in sibling skills (
verify-readme,verify-testsuse the same terse Inputs form), and honoring supplied constraints is default agent behavior, so this reads fine as-is.One small correction to the PR description: the task steps do not name each removed item. Step 3 names component, font, writing mode, and browser support target, and step 6 names target locales and fallback fonts — but "framework" and "codebase constraints" now appear nowhere in the file. No action needed if that omission is intentional.
@reply-43550.txt