chore: sync managed files with align 17.3.0 #13

jercik · 2026-10-27T11:49:14Z

jercik commented

2026-10-27 11:49:14 +00:00

Syncs managed files with @j4k/align 17.3.0 (j4k-align --fix). Changed checks.yml, dedupe-check.yml and release.yml.

🤖 Generated with Claude Code

Syncs managed files with `@j4k/align` 17.3.0 (`j4k-align --fix`). Changed `checks.yml`, `dedupe-check.yml` and `release.yml`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jercik added 1 commit

2026-10-27 11:49:14 +00:00

chore: sync managed files with align 17.3.0

Checks / reuse (pull_request) Has been skipped

Details

Checks / pr-flow-canary (pull_request) Has been skipped

Details

commit-msg / commitlint (pull_request) Successful in 5s

Details

Checks / quality-checks (26.12.1) (pull_request) Successful in 33s

Details

Checks / quality-checks (24.15.0) (pull_request) Successful in 44s

Details

Checks / qc-result (pull_request) Has been skipped

Details

Review / Review (pull_request_target) Successful in 2m38s

Details

e7b3ca4b22

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

forgejo-actions commented

2026-10-27 11:51:50 +00:00

Review 01M5YK2ZXHNQ2ZE2XDHP22H7MV — head e7b3ca4b22a5646edb844e4e7b17fc5a427e5ac1

Review — j4k-oss/askpplx @ `bc5882acf3`

Scope: diff against base tree 466cb79de8f5
Review finished: 3 succeeded, 0 failed, 7 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

low — Release header points to an ADR file that does not exist in the repository

claim: 01M5YK5MCM0R8MQQK9A5YDBQ8B
anchor: .forgejo/workflows/release.yml (snippet)

a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

lens: writing-quality · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
- pass 01M5YK61XPXVA4JES62SBZDS2F · valid: The grounded excerpt (exact match) confirms the new header comment gives a bare repo-relative path, docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md. The reviewer says they searched the unpacked tree for 'adr', '0004' and 'same-tree', found no docs/ directory, and found that the diff adds no file under docs/. That account is specific and consistent with the other two claims' independent descriptions of the tree. So a reader who follows the pointer for the reuse rationale finds nothing: the comment promises a reference that can't be followed from this repository. Even if the record exists in a template-source repository such as j4k-align, an unqualified path still reads as local, so the defect holds either way. The correction is proportionate: name the owning repository or use a full URL, or replace the parenthetical with a pointer to the reuse and qc-result jobs in checks.yml. If the file is rendered from a template, fix it in that template. Low severity is appropriate.
duplicates: 01M5YK5WT6S39X9HEAEVBDK8B8 (general-bug)
disposition: none

A reader who wants the rationale for reusing a pull request pass at the release gate follows the header comment's pointer and finds nothing. The tree has no docs/ directory and no ADR anywhere, so the pointer cannot be followed.

The new header in .forgejo/workflows/release.yml reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The diff adds no file under docs/. The only other mention of the decision is the long comment above the reuse job in checks.yml, which states the mechanism but not why same-tree reuse is acceptable.

Correction: either add the ADR at that path, or drop the parenthetical and point at the standing explanation that does exist: "see the reuse and qc-result jobs in checks.yml". The first sentence already tells the reader what the gate does, so nothing else is lost. If the ADR lives in another repository because this file is rendered from a shared template, name that repository and fix the path in the template rather than here.

Examined: a search of the unpacked tree for adr, 0004, and same-tree (only this comment and the checks.yml comments matched), the ls docs check (no such directory), and the full diff of the three workflow files. I could not check whether the file exists in the template's source repository; the tree is all I could read.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (1)
- 01M5YK4XB19V5AHT7AM0YDT49C low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in this repository
duplicate-of (1)
- 01M5YK5WT6S39X9HEAEVBDK8B8 low — release.yml points to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in this repository → 01M5YK5MCM0R8MQQK9A5YDBQ8B
unadjudicated (0)

Coverage

Coverage pass: 01M5YK2ZXNDWM536QCCT11SGGC
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	claims-emitted	1	no
writing-quality	whole	default	claims-emitted	1	no
project-docs	whole	default	claims-emitted	1	no

test-trimming — skipped-by-dispatch: no tests changed
restated-sets — skipped-by-dispatch: no enumerated sets or lists changed; only workflow steps and comments
unix-cli — skipped-by-dispatch: no CLI program or its interface changed; only CI workflow YAML
use-effect — skipped-by-dispatch: no React code changed; only CI workflow YAML
module-design — skipped-by-dispatch: no code changed; all paths are CI workflow YAML
aposd-plain — skipped-by-dispatch: no code changed; all paths are CI workflow YAML
react — skipped-by-dispatch: no React code changed; only CI workflow YAML

**Review** `01M5YK2ZXHNQ2ZE2XDHP22H7MV` — head `e7b3ca4b22a5646edb844e4e7b17fc5a427e5ac1` # Review — j4k-oss/askpplx @ bc5882acf305 Scope: diff against base tree `466cb79de8f5` Review finished: 3 succeeded, 0 failed, 7 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### low — Release header points to an ADR file that does not exist in the repository - claim: `01M5YK5MCM0R8MQQK9A5YDBQ8B` - anchor: `.forgejo/workflows/release.yml` (snippet) ``` a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md). ``` - lens: writing-quality · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M5YK61XPXVA4JES62SBZDS2F` · valid: The grounded excerpt (exact match) confirms the new header comment gives a bare repo-relative path, docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md. The reviewer says they searched the unpacked tree for 'adr', '0004' and 'same-tree', found no docs/ directory, and found that the diff adds no file under docs/. That account is specific and consistent with the other two claims' independent descriptions of the tree. So a reader who follows the pointer for the reuse rationale finds nothing: the comment promises a reference that can't be followed from this repository. Even if the record exists in a template-source repository such as j4k-align, an unqualified path still reads as local, so the defect holds either way. The correction is proportionate: name the owning repository or use a full URL, or replace the parenthetical with a pointer to the reuse and qc-result jobs in checks.yml. If the file is rendered from a template, fix it in that template. Low severity is appropriate. - duplicates: `01M5YK5WT6S39X9HEAEVBDK8B8` (general-bug) - disposition: none > A reader who wants the rationale for reusing a pull request pass at the release gate follows the header comment's pointer and finds nothing. The tree has no `docs/` directory and no ADR anywhere, so the pointer cannot be followed. > > The new header in `.forgejo/workflows/release.yml` reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The diff adds no file under `docs/`. The only other mention of the decision is the long comment above the `reuse` job in `checks.yml`, which states the mechanism but not why same-tree reuse is acceptable. > > Correction: either add the ADR at that path, or drop the parenthetical and point at the standing explanation that does exist: "see the `reuse` and `qc-result` jobs in `checks.yml`". The first sentence already tells the reader what the gate does, so nothing else is lost. If the ADR lives in another repository because this file is rendered from a shared template, name that repository and fix the path in the template rather than here. > > Examined: a search of the unpacked tree for `adr`, `0004`, and `same-tree` (only this comment and the `checks.yml` comments matched), the `ls docs` check (no such directory), and the full diff of the three workflow files. I could not check whether the file exists in the template's source repository; the tree is all I could read. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M5YK4XB19V5AHT7AM0YDT49C` low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in this repository - duplicate-of (1) - `01M5YK5WT6S39X9HEAEVBDK8B8` low — release.yml points to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in this repository → `01M5YK5MCM0R8MQQK9A5YDBQ8B` - unadjudicated (0) ## Coverage Coverage pass: 01M5YK2ZXNDWM536QCCT11SGGC Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | claims-emitted | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | claims-emitted | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: no enumerated sets or lists changed; only workflow steps and comments - unix-cli — skipped-by-dispatch: no CLI program or its interface changed; only CI workflow YAML - use-effect — skipped-by-dispatch: no React code changed; only CI workflow YAML - module-design — skipped-by-dispatch: no code changed; all paths are CI workflow YAML - aposd-plain — skipped-by-dispatch: no code changed; all paths are CI workflow YAML - react — skipped-by-dispatch: no React code changed; only CI workflow YAML

forgejo-actions reviewed

2026-10-27 11:51:50 +00:00

.forgejo/workflows/release.yml

					
				@ -5,1 +4,3 @@

				# managed quality suite on the merged revision before publishing.

				# Required PR status checks are intentionally disabled, so the release gate verifies

				# the merged revision before publishing: it runs the managed quality suite, or reuses

				# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

low — Release header points to an ADR file that does not exist in the repository

A reader who wants the rationale for reusing a pull request pass at the release gate follows the header comment's pointer and finds nothing. The tree has no docs/ directory and no ADR anywhere, so the pointer cannot be followed.

The new header in .forgejo/workflows/release.yml reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The diff adds no file under docs/. The only other mention of the decision is the long comment above the reuse job in checks.yml, which states the mechanism but not why same-tree reuse is acceptable.

Correction: either add the ADR at that path, or drop the parenthetical and point at the standing explanation that does exist: "see the reuse and qc-result jobs in checks.yml". The first sentence already tells the reader what the gate does, so nothing else is lost. If the ADR lives in another repository because this file is rendered from a shared template, name that repository and fix the path in the template rather than here.

Examined: a search of the unpacked tree for adr, 0004, and same-tree (only this comment and the checks.yml comments matched), the ls docs check (no such directory), and the full diff of the three workflow files. I could not check whether the file exists in the template's source repository; the tree is all I could read.

lens writing-quality · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M5YK5MCM0R8MQQK9A5YDBQ8B of review 01M5YK2ZXHNQ2ZE2XDHP22H7MV

**low** — Release header points to an ADR file that does not exist in the repository > A reader who wants the rationale for reusing a pull request pass at the release gate follows the header comment's pointer and finds nothing. The tree has no `docs/` directory and no ADR anywhere, so the pointer cannot be followed. > > The new header in `.forgejo/workflows/release.yml` reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The diff adds no file under `docs/`. The only other mention of the decision is the long comment above the `reuse` job in `checks.yml`, which states the mechanism but not why same-tree reuse is acceptable. > > Correction: either add the ADR at that path, or drop the parenthetical and point at the standing explanation that does exist: "see the `reuse` and `qc-result` jobs in `checks.yml`". The first sentence already tells the reader what the gate does, so nothing else is lost. If the ADR lives in another repository because this file is rendered from a shared template, name that repository and fix the path in the template rather than here. > > Examined: a search of the unpacked tree for `adr`, `0004`, and `same-tree` (only this comment and the `checks.yml` comments matched), the `ls docs` check (no such directory), and the full diff of the three workflow files. I could not check whether the file exists in the template's source repository; the tree is all I could read. lens `writing-quality` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M5YK5MCM0R8MQQK9A5YDBQ8B` of review `01M5YK2ZXHNQ2ZE2XDHP22H7MV`