chore: sync managed files with align 17.3.0 #12

jercik · 2026-10-27T11:49:17Z

jercik commented

2026-10-27 11:49:17 +00:00

Syncs managed files with @j4k/align 17.3.0 (j4k-align --fix). Changed checks.yml, dedupe-check.yml and release.yml.

🤖 Generated with Claude Code

Syncs managed files with `@j4k/align` 17.3.0 (`j4k-align --fix`). Changed `checks.yml`, `dedupe-check.yml` and `release.yml`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jercik added 1 commit

2026-10-27 11:49:17 +00:00

chore: sync managed files with align 17.3.0

Checks / reuse (pull_request) Has been skipped

Details

Checks / pr-flow-canary (pull_request) Has been skipped

Details

Checks / quality-checks (24.15.0) (pull_request) Successful in 32s

Details

Checks / qc-result (pull_request) Has been skipped

Details

commit-msg / commitlint (pull_request) Successful in 5s

Details

Checks / quality-checks (26.12.1) (pull_request) Successful in 30s

Details

Review / Review (pull_request_target) Successful in 2m22s

Details

c1ae92c72d

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

forgejo-actions commented

2026-10-27 11:51:38 +00:00

Review 01M5YK32MVDBGHH09A47V7WXXV — head c1ae92c72de4cdb47409a0a5d5ee444ee5a8bc8d

Review — j4k-oss/conventional-commit-msg @ `70008daf9d`

Scope: diff against base tree 3362f891e2f8
Review finished: 4 succeeded, 0 failed, 6 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

medium — release.yml cites an ADR file that does not exist in this repository

claim: 01M5YK53D5EP4NYG66C68TJWSY
anchor: .forgejo/workflows/release.yml (snippet)

# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

lens: writing-quality · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
- pass 01M5YK61YEZJJC8VPW18A2DBT6 · valid: Grounded exact excerpt shows release.yml's header comment citing docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md as a repo-relative path. Both reviewers independently report, with a concrete search described (tree listing, ls docs failing, grep for adr/0004 matching only this line), that the subject tree has no docs/ directory; nothing in the batch contradicts this. The defect holds either way: if the ADR lives in the alignment template's repository, a bare repo-relative path still does not resolve for a reader of this repository. The proposed remedy is sound and keeps the needed meaning, because the surrounding sentence already states the decision (run the suite or reuse a same-tree PR pass). Either name the owning repository and path, or drop the parenthetical. Make the edit in the j4k-align template so realignment does not restore the comment, or add the ADR here. Severity is overstated: a dangling pointer in a comment whose sentence is self-contained misleads no one about behavior, so I would rate it low.
duplicates: 01M5YK5HR5TDSQ7WTFPYZH6YPW (general-bug)
disposition: none

The header comment sends the reader to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md for the reasoning behind reusing a pull request pass at the release gate. A reader who wants to know why the gate may skip quality-checks, which is the safety-relevant part of this change, cannot follow the pointer here: the file is not in this repository.

The comment reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The unpacked tree has no docs/ directory at all, and a search for adr and 0004 across the tree matches only this line. The workflow files are rendered by an alignment tool (the new release.yml error message says to run j4k-align --fix), so the ADR probably lives in the template or shared repository. I could not check that, because only this repository's tree was available.

Correction: if the ADR belongs to the template repository, name that repository and path in the comment, or drop the path and leave the sentence as the self-contained summary it already is. Fixing it means editing the template that renders this file, so the next alignment run does not restore the comment. If the ADR should exist here, add it. The surrounding sentence already states the decision (run the suite or reuse a same-tree pull request pass), so nothing else needs adding; the comment only needs to stop citing a file the reader cannot open.

Examined: the full diff of release.yml, checks.yml and dedupe-check.yml, and the unpacked tree (file listing plus a grep for adr and 0004). What would refute this: an ADR at that path in the repository, or a documented convention that these rendered workflows point at a path in another repository.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (1)
- 01M5YK5HR5TDSQ7WTFPYZH6YPW low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the repository → 01M5YK53D5EP4NYG66C68TJWSY
unadjudicated (0)

Coverage

Coverage pass: 01M5YK32MZ0VGARHMHAE3EH7S8
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	claims-emitted	1	no
writing-quality	whole	default	claims-emitted	1	no
project-docs	whole	default	no-claims	1	no
unix-cli	whole	default	no-claims	1	no

test-trimming — skipped-by-dispatch: no tests changed
restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across the changes
use-effect — skipped-by-dispatch: only CI workflow YAML changed, no React Effects
module-design — skipped-by-dispatch: no code changed; only workflow YAML
aposd-plain — skipped-by-dispatch: no code changed; only workflow YAML
react — skipped-by-dispatch: only CI workflow YAML changed, no React components

**Review** `01M5YK32MVDBGHH09A47V7WXXV` — head `c1ae92c72de4cdb47409a0a5d5ee444ee5a8bc8d` # Review — j4k-oss/conventional-commit-msg @ 70008daf9d59 Scope: diff against base tree `3362f891e2f8` Review finished: 4 succeeded, 0 failed, 6 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### medium — release.yml cites an ADR file that does not exist in this repository - claim: `01M5YK53D5EP4NYG66C68TJWSY` - anchor: `.forgejo/workflows/release.yml` (snippet) ``` # a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md). ``` - lens: writing-quality · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M5YK61YEZJJC8VPW18A2DBT6` · valid: Grounded exact excerpt shows release.yml's header comment citing docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md as a repo-relative path. Both reviewers independently report, with a concrete search described (tree listing, ls docs failing, grep for adr/0004 matching only this line), that the subject tree has no docs/ directory; nothing in the batch contradicts this. The defect holds either way: if the ADR lives in the alignment template's repository, a bare repo-relative path still does not resolve for a reader of this repository. The proposed remedy is sound and keeps the needed meaning, because the surrounding sentence already states the decision (run the suite or reuse a same-tree PR pass). Either name the owning repository and path, or drop the parenthetical. Make the edit in the j4k-align template so realignment does not restore the comment, or add the ADR here. Severity is overstated: a dangling pointer in a comment whose sentence is self-contained misleads no one about behavior, so I would rate it low. - duplicates: `01M5YK5HR5TDSQ7WTFPYZH6YPW` (general-bug) - disposition: none > The header comment sends the reader to `docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md` for the reasoning behind reusing a pull request pass at the release gate. A reader who wants to know why the gate may skip quality-checks, which is the safety-relevant part of this change, cannot follow the pointer here: the file is not in this repository. > > The comment reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The unpacked tree has no `docs/` directory at all, and a search for `adr` and `0004` across the tree matches only this line. The workflow files are rendered by an alignment tool (the new release.yml error message says to run `j4k-align --fix`), so the ADR probably lives in the template or shared repository. I could not check that, because only this repository's tree was available. > > Correction: if the ADR belongs to the template repository, name that repository and path in the comment, or drop the path and leave the sentence as the self-contained summary it already is. Fixing it means editing the template that renders this file, so the next alignment run does not restore the comment. If the ADR should exist here, add it. The surrounding sentence already states the decision (run the suite or reuse a same-tree pull request pass), so nothing else needs adding; the comment only needs to stop citing a file the reader cannot open. > > Examined: the full diff of release.yml, checks.yml and dedupe-check.yml, and the unpacked tree (file listing plus a grep for `adr` and `0004`). What would refute this: an ADR at that path in the repository, or a documented convention that these rendered workflows point at a path in another repository. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (1) - `01M5YK5HR5TDSQ7WTFPYZH6YPW` low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the repository → `01M5YK53D5EP4NYG66C68TJWSY` - unadjudicated (0) ## Coverage Coverage pass: 01M5YK32MZ0VGARHMHAE3EH7S8 Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | claims-emitted | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | no-claims | 1 | no | | unix-cli | whole | default | no-claims | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across the changes - use-effect — skipped-by-dispatch: only CI workflow YAML changed, no React Effects - module-design — skipped-by-dispatch: no code changed; only workflow YAML - aposd-plain — skipped-by-dispatch: no code changed; only workflow YAML - react — skipped-by-dispatch: only CI workflow YAML changed, no React components

forgejo-actions reviewed

2026-10-27 11:51:38 +00:00

.forgejo/workflows/release.yml

					
				@ -5,1 +4,3 @@

				# managed quality suite on the merged revision before publishing.

				# Required PR status checks are intentionally disabled, so the release gate verifies

				# the merged revision before publishing: it runs the managed quality suite, or reuses

				# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

medium — release.yml cites an ADR file that does not exist in this repository

The header comment sends the reader to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md for the reasoning behind reusing a pull request pass at the release gate. A reader who wants to know why the gate may skip quality-checks, which is the safety-relevant part of this change, cannot follow the pointer here: the file is not in this repository.

The comment reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The unpacked tree has no docs/ directory at all, and a search for adr and 0004 across the tree matches only this line. The workflow files are rendered by an alignment tool (the new release.yml error message says to run j4k-align --fix), so the ADR probably lives in the template or shared repository. I could not check that, because only this repository's tree was available.

Correction: if the ADR belongs to the template repository, name that repository and path in the comment, or drop the path and leave the sentence as the self-contained summary it already is. Fixing it means editing the template that renders this file, so the next alignment run does not restore the comment. If the ADR should exist here, add it. The surrounding sentence already states the decision (run the suite or reuse a same-tree pull request pass), so nothing else needs adding; the comment only needs to stop citing a file the reader cannot open.

Examined: the full diff of release.yml, checks.yml and dedupe-check.yml, and the unpacked tree (file listing plus a grep for adr and 0004). What would refute this: an ADR at that path in the repository, or a documented convention that these rendered workflows point at a path in another repository.

lens writing-quality · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M5YK53D5EP4NYG66C68TJWSY of review 01M5YK32MVDBGHH09A47V7WXXV

**medium** — release.yml cites an ADR file that does not exist in this repository > The header comment sends the reader to `docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md` for the reasoning behind reusing a pull request pass at the release gate. A reader who wants to know why the gate may skip quality-checks, which is the safety-relevant part of this change, cannot follow the pointer here: the file is not in this repository. > > The comment reads: "the release gate verifies the merged revision before publishing: it runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)." The unpacked tree has no `docs/` directory at all, and a search for `adr` and `0004` across the tree matches only this line. The workflow files are rendered by an alignment tool (the new release.yml error message says to run `j4k-align --fix`), so the ADR probably lives in the template or shared repository. I could not check that, because only this repository's tree was available. > > Correction: if the ADR belongs to the template repository, name that repository and path in the comment, or drop the path and leave the sentence as the self-contained summary it already is. Fixing it means editing the template that renders this file, so the next alignment run does not restore the comment. If the ADR should exist here, add it. The surrounding sentence already states the decision (run the suite or reuse a same-tree pull request pass), so nothing else needs adding; the comment only needs to stop citing a file the reader cannot open. > > Examined: the full diff of release.yml, checks.yml and dedupe-check.yml, and the unpacked tree (file listing plus a grep for `adr` and `0004`). What would refute this: an ADR at that path in the repository, or a documented convention that these rendered workflows point at a path in another repository. lens `writing-quality` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M5YK53D5EP4NYG66C68TJWSY` of review `01M5YK32MVDBGHH09A47V7WXXV`