chore: sync managed files with align 17.3.0 #17
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/align-17-3-0"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Syncs managed files with
@j4k/align17.3.0 (j4k-align --fix). Changedchecks.yml,dedupe-check.ymlandrelease.yml.🤖 Generated with Claude Code
Review
01M5YK36K2TFHD503HYNJDC9AD— head23f335b09273e6062b9ebbc516ee3da66b65d092Review — j4k-oss/fta-check @
afc0f14f39Scope: diff against base tree
22371fc6babaReview finished: 4 succeeded, 0 failed, 6 skipped by dispatch
Triage: settled
Facts: current review-wide projection
Computed under:
Findings (3)
medium — reuse job comment restates the 24-hour cutoff that the lookup step defines
01M5YK5YCCSA2K7NCFYEFGX5BG.forgejo/workflows/checks.yml(snippet)01M5YK6GT6BRTF59EK2D0Z1A4J· valid: The grounded excerpt both points to the authority ('limitandcutoffin the lookup step') and copies its value ('within the last 24 hours'). The rubric's pointer exception covers only the pointer, not a value stated beside it. The reviewer quotes the authority, cutoff="$(date -u -d '24 hours ago' +%s)". Following the pointer means reading one plain line, so the copy serves no separate reader task: a reader of a job-level comment needs to know only that candidates must be recent. The copy agrees with the code today, so this is a maintenance defect, not a false statement. The fix is to say 'recent' and keep the pointer. One caveat: this is a single duplicated value, not a member list or count, so I would rate it low rather than medium.low — Comment restates the 20-second timeouts that sit on the calls it describes
01M5YK5YWGC7ZBMK1MS025KEWR.forgejo/workflows/checks.yml(snippet)01M5YK6GT6BRTF59EK2D0Z1A4J· valid: The grounded comment copies the literal '20 seconds'. The reviewer reports three separate places that set it:timeout 20in fetch_commit and--max-time 20on two curl calls. The comment has no authority of its own, so retuning any one call silently makes it wrong. That duplicated value is a supported low-severity defect. The proposed remedy goes too far, though. The clause 'each network call below is bounded' records an invariant: the deadline check only bounds the loop's runtime if every call in it has its own timeout, and a maintainer adding a call needs to know that. Under the comment guidelines that invariant should stay. A suitable correction keeps the invariant and drops the number, for example 'The candidate loop stops at this deadline; every network call below must carry its own timeout so the job finishes inside timeout-minutes.'low — release.yml points to an ADR file that does not exist in this repository
01M5YK5XWMFR14805F587MSSCZ.forgejo/workflows/release.yml(snippet)01M5YK6GT6BRTF59EK2D0Z1A4J· valid: The grounded excerpt shows the release.yml header comment pointing to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md. That comment is the only place given for the rationale behind the reuse gate. Two separate lenses report a tree listing with no docs/ directory and a grep that finds the path only in this comment. Nothing in the batch suggests the file exists. The comment uses a repo-relative path, so a maintainer who follows it in this repository finds nothing, even if a template repository holds the ADR. The remedy is sound: name the real location, add the ADR, or drop the parenthetical and keep the sentence that already states the behavior. Low severity fits.01M5YK6A5NRSJNXWCYDPPRYRHZ(general-bug)Other claims
01M5YK6A5NRSJNXWCYDPPRYRHZlow — release.yml cites an ADR file that does not exist in the repository →01M5YK5XWMFR14805F587MSSCZ01M5YK6AFFANJT1XVS16927PHRlow — qc_executed assumes the run-jobs endpoint returns a bare array with status==success; a different shape silently disables reuseCoverage
Coverage pass: 01M5YK36MY7E8E43DWJET74A30
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy
@ -50,0 +46,4 @@# pull request, the release gate skips quality-checks. Only release callers# (workflow_call with release_gate) look; pull requests always run the full# checks. A candidate is a successful pull request run of this file created# within the last 24 hours (`limit` and `cutoff` in the lookup step) whosemedium — reuse job comment restates the 24-hour cutoff that the lookup step defines
lens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M5YK5YCCSA2K7NCFYEFGX5BGof review01M5YK36K2TFHD503HYNJDC9AD@ -73,12 +78,15 @@ jobs:exit 0;;esac# The candidate loop stops at this deadline; each network call below is bounded to 20 seconds.low — Comment restates the 20-second timeouts that sit on the calls it describes
lens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M5YK5YWGC7ZBMK1MS025KEWRof review01M5YK36K2TFHD503HYNJDC9AD@ -5,1 +4,3 @@# managed quality suite on the merged revision before publishing.# Required PR status checks are intentionally disabled, so the release gate verifies# the merged revision before publishing: it runs the managed quality suite, or reuses# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).low — release.yml points to an ADR file that does not exist in this repository
lens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M5YK5XWMFR14805F587MSSCZof review01M5YK36K2TFHD503HYNJDC9AD