chore: remove npm-mirror leftovers and document the scoped package #2
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/remove-npm-mirror"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Removes the npm-mirror leftovers after align 9.0.0. The package now publishes only to the Forge registry as
@j4k-oss/perplexity-agent-mcp, so the.npm-mirrormarker,.github/workflows/release-npm.ymland thenpm-mirrorjob inrelease.yml(663 to 208 lines) are gone. The Forge publish is untouched. The remaining files are what align regenerated:AGENTS.md, one workflow comment and two check-dts messages.The README now points at the scoped Forge package and carries the registry flag on every npm command, because the
j4k-ossscope on npmjs has an unconfirmed owner. It says the unscoped package is frozen and must be uninstalled globally first, since both ship the same command.🤖 Generated with Claude Code
Review
01M5JB47ECFSH4WYG74CYNEJQP— headd503ab850acb475fbc3f1760601616baf13f65b3Review — j4k-oss/perplexity-agent-mcp @
041cee27c1Scope: diff against base tree
202843f6ef87Status: dispatched — coverage complete (4/4 slots terminal)
Facts: current review-wide projection
Computed under:
Findings (3)
medium — The model-selection summary independently copies the tool configuration
01M5JBC048B6JAF8VJZTBXWH6BREADME.md(snippet)01M5JBDQMSX222282AQPAJJJGA· valid: The exact-grounded sentence copies lookup -> sonar-pro and answer -> sonar-reasoning-pro. The reviewer identifies registerLookupTool in src/tools/lookup.ts and registerAnswerTool in src/tools/answer.ts as the authorities and lists the same mappings there, with no exclusive members. This satisfies the required comparison and establishes a medium maintenance defect: the prose independently repeats repository-selected models, rather than a vendor-defined set. The reported MCP interface gives callers no model-selection action requiring those names. The pointer exception does not exempt the members stated beside the pointers. The reported nonexistent helpers also make the current navigation misleading. Preserve the purpose that models are configured per tool and point to the actual registration functions; exact model names are unnecessary for that implementation-orientation task. The earlier adjudication supplies no concrete refutation, and the current evidence independently supports the conclusion.medium — The documented Node minimum is lower than the package requirement
01M5JBCE9G9G8KM21N9NMF6GZDREADME.md(snippet)01M5JBDQMSX222282AQPAJJJGA· valid: The exact-grounded README prerequisite allows Node.js 24.0.0 or newer. The reviewer quotes the contrasting package.json engines.node declaration as >=24.15.0. Versions from 24.0.0 through 24.14.x therefore satisfy the documentation but fall outside declared support. This is a concrete documentation mismatch; it does not depend on demonstrating a runtime crash, and installation rejection is explicitly conditional on engine enforcement. The setup reader needs the supported minimum to choose a runtime, so retaining the exact prerequisite serves a distinct task and is permitted by the task-critical-information exception. Align the README minimum with 24.15.0 or derive it from the manifest. Medium severity is appropriate. Reassessing the historical claim reveals no counterevidence or changed contract that defeats the current comparison.low — The prompt references send readers to a file that does not define them
01M5JBD1PQTNF40N2JE7YJEG5QREADME.md(snippet)01M5JBDQMSX222282AQPAJJJGA· valid: The exact-grounded passage locates LOOKUP_SYSTEM_PROMPT and ANSWER_SYSTEM_PROMPT in src/index.ts. The reviewer supplies a concrete contradictory trace: src/prompts.ts defines both constants, the lookup and answer tool modules import them from ../prompts.js and pass them as the system option to performChatCompletion, and src/index.ts has neither definitions nor re-exports. That account explains why a contributor following either reference reaches the wrong file; it is more than a bare assertion of inspection. Nothing in the batch contradicts this trace, and the historical adjudication adds no applicable refutation. Changing both references to src/prompts.ts while retaining the tool-purpose explanations repairs the navigation without duplicating prompt contents. Low severity is appropriate.Other claims
Coverage
Coverage pass: 01M5JB5JMSJDHNZ315JAARGZEJ
Accounting: complete
Slot health: healthy
01M5JA8ETMWRC2KHG7163668A8), prompt source pointers (claim01M5JA8YM5M7KK5WQRWCREVWN7) and the hand-copied tool-to-model mapping (claim01M5JA9GZB98TPGDVEAJYW34PW): all valid, and all in README text this PR did not change. The README saysv24.0.0whereengines.nodeis>=24.15.0, points atsrc/index.tsfor prompts that live insrc/prompts.ts, and namesgetLookupModel()/getAnswerModel(), which do not exist (the models are literals insrc/tools/lookup.tsandsrc/tools/answer.ts). Tracked in #3, whose edits sit outside this PR's hunks.01M5JA73P6YNA5B5XR5ZA4M0TV(the repoq guidance counts the CLI's write commands): not a defect in this PR. The sentence "It also carries one write verb:pr create" is in the generatedAGENTS.md/CLAUDE.md, which align regenerated here from the shared rulerepoq/repoq-usage.md; generated files are not edited by hand. The count is accurate today: repoq registerspr createas its only write command (src/cli/register-pr-command.ts). If repoq gains another write verb, the shared rule in the align repository needs the update, which is outside these PRs.All three findings (model-selection copy
01M5JBC048B6JAF8VJZTBXWH6B, Node minimum01M5JBCE9G9G8KM21N9NMF6GZD, prompt source pointers01M5JBD1PQTNF40N2JE7YJEG5Q) are valid, concern README text this PR did not change, and are already fixed onmainin95a19e6(#3). This review ran on a head that does not contain that commit.