feat: show lens, arm and tally below the claim body in inline comments #22

jercik · 2026-10-03T09:13:47Z

jercik commented

2026-10-03 09:13:47 +00:00

An inline review comment now reads title, explanation, then bookkeeping. The lens, arm and tally line moves from between the title and the quoted claim body to just above the claim/review footer:

**high** — <title>

> <claim body>

lens `correctness` · arm `default` · tally 2 valid / 0 invalid / 0 uncertain
claim `<id>` of review `<id>`

#20 edits the same function (commentBody), so whichever merges second needs a small rebase.

An inline review comment now reads title, explanation, then bookkeeping. The lens, arm and tally line moves from between the title and the quoted claim body to just above the claim/review footer: ``` **high** — <title> > <claim body> lens `correctness` · arm `default` · tally 2 valid / 0 invalid / 0 uncertain claim `<id>` of review `<id>` ``` #20 edits the same function (`commentBody`), so whichever merges second needs a small rebase.

jercik added 1 commit

2026-10-03 09:13:47 +00:00

feat: show lens, arm and tally below the claim body in inline comments

commit-msg / commitlint (pull_request) Successful in 28s

Details

Checks / quality-checks (pull_request) Successful in 57s

Details

Review / Review (pull_request_target) Successful in 5m36s

Details

c64c429d48

An inline review comment now reads title, explanation, then bookkeeping:
the lens/arm/tally line sits directly above the claim/review footer
instead of between the title and the quoted body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

forgejo-actions commented

2026-10-03 09:19:23 +00:00

Review 01M40GN474CY6TXFNCEY1CBRGN — head c64c429d4836515c983f24600bb16199355caae4

Review — j4k-oss/review-wrapper @ `3c6708711f`

Scope: diff against base tree c3bd7d27b1ad
Status: dispatched — coverage complete (3/3 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v3",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

low — Inline comment footer leaves triage counts and flags undefined

claim: 01M40GVKZ7V197W8RBPNE008QS
anchor: src/reconcile/inline.ts (snippet)

    `lens \`${claim.lens}\` · arm \`${claim.arm}\` · ${tally}${wavering}`,

lens: writing-quality · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
disposition: none

I examined commentBody, its createInlineReconciler caller, the expected comment bodies in inline.test.ts, and the bundled ProjectedClaim schema. The formatter posts this line as the footer of every mapped finding's PR review comment. The schema calls the numbers a VerdictTally, but the reader sees only tally 2 valid / 1 invalid / 0 uncertain; it does not say that these are verdicts on this claim. arm and wavering are also project-local labels with no explanation in the comment. A PR reader cannot tell whether the numbers count findings, reviewers, or decisions, or what the wavering flag asks them to do. The writing standard calls for defining project-local terms on first use and making claims verifiable. Name the unit, such as 'triage verdicts', and briefly explain or omit the arm and wavering labels according to their intended reader use. Keep the claim and review IDs for traceability. This preserves useful metadata while making the footer interpretable. This is a static reading; I did not render a forge comment. A visible legend supplied alongside every inline comment would refute the need for a local explanation; this formatter does not supply one.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M40GN48VDYCT1WFEFBA63ARM
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	claims-emitted	1	no
test-trimming	whole	default	no-claims	1	no

**Review** `01M40GN474CY6TXFNCEY1CBRGN` — head `c64c429d4836515c983f24600bb16199355caae4` # Review — j4k-oss/review-wrapper @ 3c6708711f1c Scope: diff against base tree `c3bd7d27b1ad` Status: dispatched — coverage complete (3/3 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v3", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### low — Inline comment footer leaves triage counts and flags undefined - claim: `01M40GVKZ7V197W8RBPNE008QS` - anchor: `src/reconcile/inline.ts` (snippet) ``` `lens \`${claim.lens}\` · arm \`${claim.arm}\` · ${tally}${wavering}`, ``` - lens: writing-quality · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - disposition: none > I examined `commentBody`, its `createInlineReconciler` caller, the expected comment bodies in `inline.test.ts`, and the bundled `ProjectedClaim` schema. The formatter posts this line as the footer of every mapped finding's PR review comment. The schema calls the numbers a `VerdictTally`, but the reader sees only `tally 2 valid / 1 invalid / 0 uncertain`; it does not say that these are verdicts on this claim. `arm` and `wavering` are also project-local labels with no explanation in the comment. A PR reader cannot tell whether the numbers count findings, reviewers, or decisions, or what the wavering flag asks them to do. The writing standard calls for defining project-local terms on first use and making claims verifiable. Name the unit, such as 'triage verdicts', and briefly explain or omit the arm and wavering labels according to their intended reader use. Keep the claim and review IDs for traceability. This preserves useful metadata while making the footer interpretable. This is a static reading; I did not render a forge comment. A visible legend supplied alongside every inline comment would refute the need for a local explanation; this formatter does not supply one. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M40GN48VDYCT1WFEFBA63ARM Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | test-trimming | whole | default | no-claims | 1 | no |

🚀 1

forgejo-actions reviewed

2026-10-03 09:19:23 +00:00

src/reconcile/inline.ts

					
				@ -21,3 +20,4 @@

				    "",

				    quoted,

				    "",

				    `lens \`${claim.lens}\` · arm \`${claim.arm}\` · ${tally}${wavering}`,

low — Inline comment footer leaves triage counts and flags undefined
lens writing-quality · arm default · tally 1 valid / 0 invalid / 0 uncertain

I examined commentBody, its createInlineReconciler caller, the expected comment bodies in inline.test.ts, and the bundled ProjectedClaim schema. The formatter posts this line as the footer of every mapped finding's PR review comment. The schema calls the numbers a VerdictTally, but the reader sees only tally 2 valid / 1 invalid / 0 uncertain; it does not say that these are verdicts on this claim. arm and wavering are also project-local labels with no explanation in the comment. A PR reader cannot tell whether the numbers count findings, reviewers, or decisions, or what the wavering flag asks them to do. The writing standard calls for defining project-local terms on first use and making claims verifiable. Name the unit, such as 'triage verdicts', and briefly explain or omit the arm and wavering labels according to their intended reader use. Keep the claim and review IDs for traceability. This preserves useful metadata while making the footer interpretable. This is a static reading; I did not render a forge comment. A visible legend supplied alongside every inline comment would refute the need for a local explanation; this formatter does not supply one.

claim 01M40GVKZ7V197W8RBPNE008QS of review 01M40GN474CY6TXFNCEY1CBRGN

**low** — Inline comment footer leaves triage counts and flags undefined lens `writing-quality` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain > I examined `commentBody`, its `createInlineReconciler` caller, the expected comment bodies in `inline.test.ts`, and the bundled `ProjectedClaim` schema. The formatter posts this line as the footer of every mapped finding's PR review comment. The schema calls the numbers a `VerdictTally`, but the reader sees only `tally 2 valid / 1 invalid / 0 uncertain`; it does not say that these are verdicts on this claim. `arm` and `wavering` are also project-local labels with no explanation in the comment. A PR reader cannot tell whether the numbers count findings, reviewers, or decisions, or what the wavering flag asks them to do. The writing standard calls for defining project-local terms on first use and making claims verifiable. Name the unit, such as 'triage verdicts', and briefly explain or omit the arm and wavering labels according to their intended reader use. Keep the claim and review IDs for traceability. This preserves useful metadata while making the footer interpretable. This is a static reading; I did not render a forge comment. A visible legend supplied alongside every inline comment would refute the need for a local explanation; this formatter does not supply one. claim `01M40GVKZ7V197W8RBPNE008QS` of review `01M40GN474CY6TXFNCEY1CBRGN`

👎 1

Declining. This pull request only moves the lens/arm/tally line below the claim body. The wording of that line (arm, the tally counts, wavering) is unchanged from main, so explaining those terms is outside this change.

Declining. This pull request only moves the lens/arm/tally line below the claim body. The wording of that line (`arm`, the tally counts, `wavering`) is unchanged from `main`, so explaining those terms is outside this change.

jercik marked this conversation as resolved

jercik merged commit 8ade433fdc into main

2026-10-03 16:18:02 +00:00

jercik deleted branch feat/defect-first-inline-comments

2026-10-03 16:18:02 +00:00

jercik referenced this pull request from a commit

2026-10-03 16:18:03 +00:00

feat: show lens, arm and tally below the claim body in inline comments (#22)

Sign in to join this conversation.

No reviewers

No labels

No milestone