test: name both halves of the credentials importer assertion #47

jercik · 2026-10-05T06:41:37Z

jercik commented

2026-10-05 06:41:37 +00:00

Follow-up to #45 (thread 126678, claim 01M45BRYXYXD3CFKXYP142GWYD): the credentials isolation test is renamed "is imported by src/main.ts and no other wrapper module", so its name covers both halves of the assertion #45 introduced. It is stacked on #45 and merges after it.

🤖 Generated with Claude Code

Follow-up to #45 (thread 126678, claim 01M45BRYXYXD3CFKXYP142GWYD): the credentials isolation test is renamed "is imported by src/main.ts and no other wrapper module", so its name covers both halves of the assertion #45 introduced. It is stacked on #45 and merges after it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jercik added 1 commit

2026-10-05 06:41:37 +00:00

test: name both halves of the credentials importer assertion

commit-msg / commitlint (pull_request) Successful in 23s

Details

Checks / quality-checks (pull_request) Successful in 46s

Details

Review / Review (pull_request_target) Has been cancelled

Details

d6f4ca7c08

The isolation test now requires src/main.ts to be the one importer of
src/credentials.ts, but its name still said only that no other module
imports it. A failure when main.ts drops the import would read as a
wrong test rather than a missing importer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jercik referenced this pull request

2026-10-05 06:41:49 +00:00

test: read the credentials isolation imports from the esbuild graph #45

jercik referenced this pull request

2026-10-05 06:41:52 +00:00

test: read the credentials isolation imports from the esbuild graph #45

forgejo-actions commented

2026-10-05 06:42:56 +00:00

Review 01M45PRX7R716RG00161A70K22 — head 54bcd31ac7b73f87449cbf07190dc85bcd7188f7

Review — j4k-oss/review-wrapper @ `8869a4f97f`

Scope: diff against base tree bbcbbdc9f6bd
Status: dispatched — coverage complete (5/5 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

medium — Test name restates the credentials importer set

claim: 01M45Q05JJA4HM8A14HTX8SF9F
anchor: src/credentials.test.ts (snippet)

  it("is imported by src/main.ts and no other wrapper module", () => {

lens: restated-sets · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
- pass 01M45Q1BH8TVE7QK1CMKTNJKE2 · valid: Grounded exact anchor confirms the test name 'is imported by src/main.ts and no other wrapper module'. The body names the source of the set: the import graph under src/, which the test reads via importsByModule() and filters for edges to src/credentials.ts. It lists the source's members as [src/main.ts] and the copy's members as [src/main.ts], and says no member appears in only one list. The name also claims completeness with 'no other'. The test-name exception does not apply. The guideline excludes names that list members the body reads from the code under test, or that claim completeness about a set the code defines, and this name does both. The test's comparison literal does not make the name a source. None of the other exceptions apply: the set is not external or fixed by definition, the name is not a dated record, and readers can open the source. Medium severity is correct because the copy still agrees with the source. The proposed rename, 'enforces the credentials importer boundary', fixes the defect without restating the set.
disposition: none

The test label duplicates the complete production importer set, so an accepted change to that set requires a separate prose edit to keep test output accurate. The copy currently agrees with the source; this is a maintenance defect rather than an existing mismatch.

The defining source is the import graph under src/, with the credentials import in src/main.ts. Its members are [src/main.ts]. The label covers [src/main.ts], and "no other wrapper module" claims completeness. No member appears in only one list. The body obtains the actual members through importsByModule(), filters edges targeting src/credentials.ts, and compares the result with ["src/main.ts"]. That assertion does not make the prose a source. The test-name exception does not apply because the body reads the members from production code and the name claims completeness about that set. Readers can open the source, and this is neither a dated record nor an external or fixed set.

Rename the test to "enforces the credentials importer boundary". Keep the executable assertion as the boundary check; the label needs no member detail.

I read src/credentials.test.ts in full, including sourceFiles() and importsByModule(), read src/credentials.ts and src/main.ts, and searched TypeScript sources for credentials references and import declarations. The test helper excludes .test.ts files, so the test file's own credentials import is outside the compared set. This is a static source trace; I did not execute the test or its esbuild scan. The import graph and the helper's filtering establish the comparison; an additional resolved credentials importer would refute the current agreement and make the copy already stale.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M45PRXAKZ7J5AY3BNPRARA6K
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	no-claims	1	no
test-trimming	whole	default	no-claims	1	no
restated-sets	whole	default	claims-emitted	1	no
project-docs	whole	default	no-claims	1	no

**Review** `01M45PRX7R716RG00161A70K22` — head `54bcd31ac7b73f87449cbf07190dc85bcd7188f7` # Review — j4k-oss/review-wrapper @ 8869a4f97f96 Scope: diff against base tree `bbcbbdc9f6bd` Status: dispatched — coverage complete (5/5 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### medium — Test name restates the credentials importer set - claim: `01M45Q05JJA4HM8A14HTX8SF9F` - anchor: `src/credentials.test.ts` (snippet) ``` it("is imported by src/main.ts and no other wrapper module", () => { ``` - lens: restated-sets · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M45Q1BH8TVE7QK1CMKTNJKE2` · valid: Grounded exact anchor confirms the test name 'is imported by src/main.ts and no other wrapper module'. The body names the source of the set: the import graph under src/, which the test reads via importsByModule() and filters for edges to src/credentials.ts. It lists the source's members as [src/main.ts] and the copy's members as [src/main.ts], and says no member appears in only one list. The name also claims completeness with 'no other'. The test-name exception does not apply. The guideline excludes names that list members the body reads from the code under test, or that claim completeness about a set the code defines, and this name does both. The test's comparison literal does not make the name a source. None of the other exceptions apply: the set is not external or fixed by definition, the name is not a dated record, and readers can open the source. Medium severity is correct because the copy still agrees with the source. The proposed rename, 'enforces the credentials importer boundary', fixes the defect without restating the set. - disposition: none > The test label duplicates the complete production importer set, so an accepted change to that set requires a separate prose edit to keep test output accurate. The copy currently agrees with the source; this is a maintenance defect rather than an existing mismatch. > > The defining source is the import graph under src/, with the credentials import in src/main.ts. Its members are [src/main.ts]. The label covers [src/main.ts], and "no other wrapper module" claims completeness. No member appears in only one list. The body obtains the actual members through importsByModule(), filters edges targeting src/credentials.ts, and compares the result with ["src/main.ts"]. That assertion does not make the prose a source. The test-name exception does not apply because the body reads the members from production code and the name claims completeness about that set. Readers can open the source, and this is neither a dated record nor an external or fixed set. > > Rename the test to "enforces the credentials importer boundary". Keep the executable assertion as the boundary check; the label needs no member detail. > > I read src/credentials.test.ts in full, including sourceFiles() and importsByModule(), read src/credentials.ts and src/main.ts, and searched TypeScript sources for credentials references and import declarations. The test helper excludes .test.ts files, so the test file's own credentials import is outside the compared set. This is a static source trace; I did not execute the test or its esbuild scan. The import graph and the helper's filtering establish the comparison; an additional resolved credentials importer would refute the current agreement and make the copy already stale. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M45PRXAKZ7J5AY3BNPRARA6K Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | test-trimming | whole | default | no-claims | 1 | no | | restated-sets | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | no-claims | 1 | no |

🚀 1

jercik changed target branch from test/wrapped-import-scan to main

2026-10-05 09:36:54 +00:00

jercik force-pushed test/credentials-importer-test-name from d6f4ca7c08

commit-msg / commitlint (pull_request) Successful in 23s

Details

Checks / quality-checks (pull_request) Successful in 46s

Details

Review / Review (pull_request_target) Has been cancelled

Details

to 54bcd31ac7

commit-msg / commitlint (pull_request) Successful in 24s

Details

Checks / quality-checks (pull_request) Successful in 48s

Details

Review / Review (pull_request_target) Successful in 6m7s

Details

2026-10-05 09:36:56 +00:00

Compare

jercik merged commit f53a6d661e into main

2026-10-05 09:37:59 +00:00

jercik referenced this pull request from a commit

2026-10-05 09:37:59 +00:00

test: name both halves of the credentials importer assertion (#47)

forgejo-actions reviewed

2026-10-05 09:43:03 +00:00

src/credentials.test.ts

					
				@ -207,3 +207,3 @@

				  });

				  it("is imported by no wrapper module other than src/main.ts", () => {

				  it("is imported by src/main.ts and no other wrapper module", () => {

medium — Test name restates the credentials importer set

The test label duplicates the complete production importer set, so an accepted change to that set requires a separate prose edit to keep test output accurate. The copy currently agrees with the source; this is a maintenance defect rather than an existing mismatch.

The defining source is the import graph under src/, with the credentials import in src/main.ts. Its members are [src/main.ts]. The label covers [src/main.ts], and "no other wrapper module" claims completeness. No member appears in only one list. The body obtains the actual members through importsByModule(), filters edges targeting src/credentials.ts, and compares the result with ["src/main.ts"]. That assertion does not make the prose a source. The test-name exception does not apply because the body reads the members from production code and the name claims completeness about that set. Readers can open the source, and this is neither a dated record nor an external or fixed set.

Rename the test to "enforces the credentials importer boundary". Keep the executable assertion as the boundary check; the label needs no member detail.

I read src/credentials.test.ts in full, including sourceFiles() and importsByModule(), read src/credentials.ts and src/main.ts, and searched TypeScript sources for credentials references and import declarations. The test helper excludes .test.ts files, so the test file's own credentials import is outside the compared set. This is a static source trace; I did not execute the test or its esbuild scan. The import graph and the helper's filtering establish the comparison; an additional resolved credentials importer would refute the current agreement and make the copy already stale.

lens restated-sets · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M45Q05JJA4HM8A14HTX8SF9F of review 01M45PRX7R716RG00161A70K22

**medium** — Test name restates the credentials importer set > The test label duplicates the complete production importer set, so an accepted change to that set requires a separate prose edit to keep test output accurate. The copy currently agrees with the source; this is a maintenance defect rather than an existing mismatch. > > The defining source is the import graph under src/, with the credentials import in src/main.ts. Its members are [src/main.ts]. The label covers [src/main.ts], and "no other wrapper module" claims completeness. No member appears in only one list. The body obtains the actual members through importsByModule(), filters edges targeting src/credentials.ts, and compares the result with ["src/main.ts"]. That assertion does not make the prose a source. The test-name exception does not apply because the body reads the members from production code and the name claims completeness about that set. Readers can open the source, and this is neither a dated record nor an external or fixed set. > > Rename the test to "enforces the credentials importer boundary". Keep the executable assertion as the boundary check; the label needs no member detail. > > I read src/credentials.test.ts in full, including sourceFiles() and importsByModule(), read src/credentials.ts and src/main.ts, and searched TypeScript sources for credentials references and import declarations. The test helper excludes .test.ts files, so the test file's own credentials import is outside the compared set. This is a static source trace; I did not execute the test or its esbuild scan. The import graph and the helper's filtering establish the comparison; an additional resolved credentials importer would refute the current agreement and make the copy already stale. lens `restated-sets` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M45Q05JJA4HM8A14HTX8SF9F` of review `01M45PRX7R716RG00161A70K22`

Sign in to join this conversation.

No reviewers

No labels

No milestone

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

j4k-oss/review-wrapper!47

Rows
Columns