fix: bundle freshness should handle pnpm store paths with spaces #59

Merged
jercik merged 1 commit from fix/bundle-store-spaces into main 2026-10-06 06:25:35 +00:00
Owner

Bundle freshness now passes when the pnpm store path contains spaces, including Library/Application Support. A regression covers the path that previously escaped normalization.

A frozen-lockfile rebuild from a store containing spaces matches the committed dist/index.mjs byte-for-byte. Fleet commit pins stay unchanged.

Bundle freshness now passes when the pnpm store path contains spaces, including `Library/Application Support`. A regression covers the path that previously escaped normalization. A frozen-lockfile rebuild from a store containing spaces matches the committed `dist/index.mjs` byte-for-byte. Fleet commit pins stay unchanged.
fix: normalize bundle paths from pnpm stores with spaces
All checks were successful
commit-msg / commitlint (pull_request) Successful in 23s
Checks / quality-checks (pull_request) Successful in 47s
Review / Review (pull_request_target) Successful in 1m5s
a8528c8267

Review 01M47VE7FTXJ3AFQ79NJS2TPJ2 — head a8528c826710912a36f394ee9bc65b62bbfd8649

Review — j4k-oss/review-wrapper @ 4a7b6e6bad

Scope: diff against base tree 53f33d0ed000
Status: dispatched — coverage complete (5/5 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

  • general-bug (whole/default): no-claims
  • writing-quality (whole/default): no-claims
  • test-trimming (whole/default): no-claims
  • restated-sets (whole/default): no-claims
  • project-docs (whole/default): no-claims

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (0)
  • duplicate-of (0)
  • unadjudicated (0)

Coverage

Coverage pass: 01M47VE7HHAZHZRC0HS6MAB9WZ
Accounting: complete
Slot health: healthy

lens part arm unit status runs loss
general-bug whole default no-claims 1 no
writing-quality whole default no-claims 1 no
test-trimming whole default no-claims 1 no
restated-sets whole default no-claims 1 no
project-docs whole default no-claims 1 no
<!-- review:summary --> **Review** `01M47VE7FTXJ3AFQ79NJS2TPJ2` — head `a8528c826710912a36f394ee9bc65b62bbfd8649` # Review — j4k-oss/review-wrapper @ 4a7b6e6bad21 Scope: diff against base tree `53f33d0ed000` Status: dispatched — coverage complete (5/5 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): no-claims - test-trimming (whole/default): no-claims - restated-sets (whole/default): no-claims - project-docs (whole/default): no-claims ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M47VE7HHAZHZRC0HS6MAB9WZ Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | no-claims | 1 | no | | test-trimming | whole | default | no-claims | 1 | no | | restated-sets | whole | default | no-claims | 1 | no | | project-docs | whole | default | no-claims | 1 | no |
jercik merged commit b2e3824d48 into main 2026-10-06 06:25:35 +00:00
jercik deleted branch fix/bundle-store-spaces 2026-10-06 06:25:35 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/review-wrapper!59
No description provided.