chore: update review wrapper pin #16

jercik · 2026-10-02T21:40:54Z

jercik commented

2026-10-02 21:40:54 +00:00

Moves the review wrapper to 5e2546b, which tolerates failure codes it doesn't recognise (such as provider-capacity from review service 2.8.0) instead of exiting 1. Rendered by @j4k/align 3.3.3.

Moves the review wrapper to `5e2546b`, which tolerates failure codes it doesn't recognise (such as `provider-capacity` from review service 2.8.0) instead of exiting 1. Rendered by `@j4k/align` 3.3.3.

jercik added 1 commit

2026-10-02 21:40:54 +00:00

chore: update review wrapper pin

commit-msg / commitlint (pull_request) Successful in 18s

Details

Checks / quality-checks (26.5.0) (pull_request) Successful in 33s

Details

Checks / quality-checks (24.15.0) (pull_request) Successful in 35s

Details

Review / Review (pull_request_target) Successful in 5m54s

Details

c5321cb697

forgejo-actions commented

2026-10-02 21:46:47 +00:00

Review 01M3Z90E4PT5B15DET1HMRPXTX — head c5321cb697b6fb311c91abbf859d4173f2ae6edd

Review — j4k-oss/tropkod-client @ `34d5b3dc60`

Scope: diff against base tree 2f0fd3baa4d2
Status: dispatched — coverage complete (3/3 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v3",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

medium — Dispatch help omits the required main branch selection

claim: 01M3Z95Y0A4NQBQQ43PTX5T99P
anchor: .forgejo/workflows/review.yml (snippet)

description: "Positive pull request number without a # prefix or leading zeros (for example, 123)"

lens: writing-quality · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
disposition: none

I read the workflow_dispatch input, the review job condition, and the surrounding workflow comments. The input help tells an operator how to format pr_number, but not that a manual run must be dispatched from main. The job condition permits workflow_dispatch only when github.ref is refs/heads/main; the file also explains that an off-main dispatch is skipped and creates no PR Review check. An operator can therefore enter a valid PR number on another selected ref and get a skipped run instead of a review. Add the main-ref requirement to this user-facing help (or adjacent dispatch guidance) while retaining the canonical-number example. The writing-for-agents guidance says to attach conditions to the action they govern and state non-obvious boundaries. The code establishes the condition statically; I did not run a Forgejo dispatch, so the exact UI presentation remains unverified.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (0)
duplicate-of (0)
unadjudicated (0)

Coverage

Coverage pass: 01M3Z90E85QT5CKZBKV8T4JZJ3
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	claims-emitted	1	no
test-trimming	whole	default	no-claims	1	no

**Review** `01M3Z90E4PT5B15DET1HMRPXTX` — head `c5321cb697b6fb311c91abbf859d4173f2ae6edd` # Review — j4k-oss/tropkod-client @ 34d5b3dc6092 Scope: diff against base tree `2f0fd3baa4d2` Status: dispatched — coverage complete (3/3 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v3", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### medium — Dispatch help omits the required main branch selection - claim: `01M3Z95Y0A4NQBQQ43PTX5T99P` - anchor: `.forgejo/workflows/review.yml` (snippet) ``` description: "Positive pull request number without a # prefix or leading zeros (for example, 123)" ``` - lens: writing-quality · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - disposition: none > I read the workflow_dispatch input, the review job condition, and the surrounding workflow comments. The input help tells an operator how to format pr_number, but not that a manual run must be dispatched from main. The job condition permits workflow_dispatch only when github.ref is refs/heads/main; the file also explains that an off-main dispatch is skipped and creates no PR Review check. An operator can therefore enter a valid PR number on another selected ref and get a skipped run instead of a review. Add the main-ref requirement to this user-facing help (or adjacent dispatch guidance) while retaining the canonical-number example. The writing-for-agents guidance says to attach conditions to the action they govern and state non-obvious boundaries. The code establishes the condition statically; I did not run a Forgejo dispatch, so the exact UI presentation remains unverified. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (0) - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M3Z90E85QT5CKZBKV8T4JZJ3 Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | test-trimming | whole | default | no-claims | 1 | no |

🚀 1

forgejo-actions reviewed

2026-10-02 21:46:48 +00:00

.forgejo/workflows/review.yml

					
				@ -60,3 +60,3 @@

				    inputs:

				      pr_number:

				        description: Pull request number to re-ask a review for

				        description: "Positive pull request number without a # prefix or leading zeros (for example, 123)"

medium — Dispatch help omits the required main branch selection
lens writing-quality · arm default · tally 1 valid / 0 invalid / 0 uncertain

I read the workflow_dispatch input, the review job condition, and the surrounding workflow comments. The input help tells an operator how to format pr_number, but not that a manual run must be dispatched from main. The job condition permits workflow_dispatch only when github.ref is refs/heads/main; the file also explains that an off-main dispatch is skipped and creates no PR Review check. An operator can therefore enter a valid PR number on another selected ref and get a skipped run instead of a review. Add the main-ref requirement to this user-facing help (or adjacent dispatch guidance) while retaining the canonical-number example. The writing-for-agents guidance says to attach conditions to the action they govern and state non-obvious boundaries. The code establishes the condition statically; I did not run a Forgejo dispatch, so the exact UI presentation remains unverified.

claim 01M3Z95Y0A4NQBQQ43PTX5T99P of review 01M3Z90E4PT5B15DET1HMRPXTX

**medium** — Dispatch help omits the required main branch selection lens `writing-quality` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain > I read the workflow_dispatch input, the review job condition, and the surrounding workflow comments. The input help tells an operator how to format pr_number, but not that a manual run must be dispatched from main. The job condition permits workflow_dispatch only when github.ref is refs/heads/main; the file also explains that an off-main dispatch is skipped and creates no PR Review check. An operator can therefore enter a valid PR number on another selected ref and get a skipped run instead of a review. Add the main-ref requirement to this user-facing help (or adjacent dispatch guidance) while retaining the canonical-number example. The writing-for-agents guidance says to attach conditions to the action they govern and state non-obvious boundaries. The code establishes the condition statically; I did not run a Forgejo dispatch, so the exact UI presentation remains unverified. claim `01M3Z95Y0A4NQBQQ43PTX5T99P` of review `01M3Z90E4PT5B15DET1HMRPXTX`

🚀 1

jercik marked this conversation as resolved

jercik commented

2026-10-02 21:48:01 +00:00

Replying to review comment #104745

Acknowledged, no change. The workflow_dispatch input text is rendered by @j4k/align 3.3.3; this PR only rolls the wrapper pin, and a hand edit here would drift from the template. The suggestion belongs in the align template, not this one-line pin change.

> Replying to review comment #104745 Acknowledged, no change. The `workflow_dispatch` input text is rendered by `@j4k/align` 3.3.3; this PR only rolls the wrapper pin, and a hand edit here would drift from the template. The suggestion belongs in the align template, not this one-line pin change.

jercik merged commit e8288172d4 into main

2026-10-02 21:48:15 +00:00

jercik referenced this pull request from a commit

2026-10-02 21:48:16 +00:00

chore: update review wrapper pin (#16)

Sign in to join this conversation.

No reviewers

No labels

No milestone

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

j4k-oss/tropkod-client!16

Rows
Columns