chore: sync managed files with align 17.3.0 #14

jercik · 2026-10-27T11:56:21Z

jercik commented

2026-10-27 11:56:21 +00:00

Syncs managed files with @j4k/align 17.3.0 (j4k-align --fix).

It updates the checks.yml, dedupe-check.yml and release.yml workflows.

🤖 Generated with Claude Code

Syncs managed files with `@j4k/align` 17.3.0 (`j4k-align --fix`). It updates the `checks.yml`, `dedupe-check.yml` and `release.yml` workflows. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jercik added 1 commit

2026-10-27 11:56:21 +00:00

chore: sync managed files with align 17.3.0

Checks / reuse (pull_request) Has been skipped

Details

Checks / pr-flow-canary (pull_request) Has been skipped

Details

commit-msg / commitlint (pull_request) Successful in 4s

Details

Checks / quality-checks (26.12.1) (pull_request) Successful in 48s

Details

Checks / quality-checks (24.15.0) (pull_request) Successful in 55s

Details

Checks / qc-result (pull_request) Has been skipped

Details

Review / Review (pull_request_target) Successful in 2m41s

Details

26b7d2a6e0

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

forgejo-actions commented

2026-10-27 11:59:02 +00:00

Review 01M5YKG50JDJD7M5SX6MCTYVT0 — head 26b7d2a6e0be9a012503d56d01c55c98040b40bb

Review — j4k-oss/worktree-add @ `b1e60edb65`

Scope: diff against base tree 75b594869387
Review finished: 4 succeeded, 0 failed, 6 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

low — release.yml points to ADR 0004, which does not exist in the tree

claim: 01M5YKJ8TXF09V2TT0784STV0J
anchor: .forgejo/workflows/release.yml (snippet)

# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

lens: writing-quality · arm: default
verdicts: 1 valid / 0 invalid / 0 uncertain
- pass 01M5YKJY7YVCV34FRC6J8TDKG2 · valid: The grounded exact snippet shows that the release.yml header comment sends readers to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md for the same-tree reuse rationale. The reviewer reports listing docs/adr, which holds only 0001-next-typegen-after-install.md, and grepping for '0004', which matched only a pnpm-lock hash. The general-bug claim reports the same listing independently. So the pointer promises information at a path that does not exist, and a reader who follows it finds nothing. A false pointer is a documentation defect, and low severity fits. Both remedies are proportionate: drop the parenthetical and point at the reuse/qc-result jobs in checks.yml that implement the mechanism, or add the ADR if the decision meets the ADR test. The template caveat is sound. If j4k-align renders release.yml, the correction belongs in the template repository. The batch cannot settle that, but either way the comment is wrong in this tree.
duplicates: 01M5YKJG3D140BYY7GXHCX0PZD (general-bug)
disposition: none

A maintainer who wants to know why the release gate may skip the quality suite follows this pointer and finds no file. The header comment in release.yml now says the gate 'runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)'. The subject tree's docs/adr/ holds only 0001-next-typegen-after-install.md, and a grep for '0004' across the tree finds no other reference to such an ADR (the only other hit is a hash in pnpm-lock.yaml). The reuse rules therefore live only in the comments in checks.yml (the reuse job header and the qc-result header), which that file does not mention as the home. Correction: either add the ADR in the same change (the rationale for trusting a pull request pass on an identical tree, the 24-hour window, and the rejected alternative of always rerunning), or drop the parenthetical and point at the reuse and qc-result jobs in checks.yml, which are the authority for the mechanism. If release.yml is rendered from a template in another repository (its error message tells the reader to run j4k-align --fix, which suggests so), correct the template, since the ADR may exist only there. I read release.yml, checks.yml and the docs/adr directory; I could not check any other repository for the ADR.

Other claims

grounding-pending (0)
ungrounded (0)
rejected (1)
- 01M5YKJ5X41PSYEFF9W9MVB9AE low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the tree
duplicate-of (1)
- 01M5YKJG3D140BYY7GXHCX0PZD low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the tree → 01M5YKJ8TXF09V2TT0784STV0J
unadjudicated (0)

Coverage

Coverage pass: 01M5YKG50YK357NQXPEKAKMS0V
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	claims-emitted	1	no
writing-quality	whole	default	claims-emitted	1	no
project-docs	whole	default	claims-emitted	1	no
unix-cli	whole	default	no-claims	1	no

test-trimming — skipped-by-dispatch: no tests changed
restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across files in the changes
use-effect — skipped-by-dispatch: no React code changed; only CI workflow YAML
module-design — skipped-by-dispatch: no code changed; only CI workflow YAML
aposd-plain — skipped-by-dispatch: no code changed; only CI workflow YAML
react — skipped-by-dispatch: no React components changed; only CI workflow YAML

**Review** `01M5YKG50JDJD7M5SX6MCTYVT0` — head `26b7d2a6e0be9a012503d56d01c55c98040b40bb` # Review — j4k-oss/worktree-add @ b1e60edb6586 Scope: diff against base tree `75b594869387` Review finished: 4 succeeded, 0 failed, 6 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### low — release.yml points to ADR 0004, which does not exist in the tree - claim: `01M5YKJ8TXF09V2TT0784STV0J` - anchor: `.forgejo/workflows/release.yml` (snippet) ``` # a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md). ``` - lens: writing-quality · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M5YKJY7YVCV34FRC6J8TDKG2` · valid: The grounded exact snippet shows that the release.yml header comment sends readers to docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md for the same-tree reuse rationale. The reviewer reports listing docs/adr, which holds only 0001-next-typegen-after-install.md, and grepping for '0004', which matched only a pnpm-lock hash. The general-bug claim reports the same listing independently. So the pointer promises information at a path that does not exist, and a reader who follows it finds nothing. A false pointer is a documentation defect, and low severity fits. Both remedies are proportionate: drop the parenthetical and point at the reuse/qc-result jobs in checks.yml that implement the mechanism, or add the ADR if the decision meets the ADR test. The template caveat is sound. If j4k-align renders release.yml, the correction belongs in the template repository. The batch cannot settle that, but either way the comment is wrong in this tree. - duplicates: `01M5YKJG3D140BYY7GXHCX0PZD` (general-bug) - disposition: none > A maintainer who wants to know why the release gate may skip the quality suite follows this pointer and finds no file. The header comment in release.yml now says the gate 'runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)'. The subject tree's docs/adr/ holds only 0001-next-typegen-after-install.md, and a grep for '0004' across the tree finds no other reference to such an ADR (the only other hit is a hash in pnpm-lock.yaml). The reuse rules therefore live only in the comments in checks.yml (the `reuse` job header and the `qc-result` header), which that file does not mention as the home. Correction: either add the ADR in the same change (the rationale for trusting a pull request pass on an identical tree, the 24-hour window, and the rejected alternative of always rerunning), or drop the parenthetical and point at the `reuse` and `qc-result` jobs in checks.yml, which are the authority for the mechanism. If release.yml is rendered from a template in another repository (its error message tells the reader to run `j4k-align --fix`, which suggests so), correct the template, since the ADR may exist only there. I read release.yml, checks.yml and the docs/adr directory; I could not check any other repository for the ADR. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M5YKJ5X41PSYEFF9W9MVB9AE` low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the tree - duplicate-of (1) - `01M5YKJG3D140BYY7GXHCX0PZD` low — release.yml cites docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md, which does not exist in the tree → `01M5YKJ8TXF09V2TT0784STV0J` - unadjudicated (0) ## Coverage Coverage pass: 01M5YKG50YK357NQXPEKAKMS0V Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | claims-emitted | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | claims-emitted | 1 | no | | unix-cli | whole | default | no-claims | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: no enumerated sets or lists restated across files in the changes - use-effect — skipped-by-dispatch: no React code changed; only CI workflow YAML - module-design — skipped-by-dispatch: no code changed; only CI workflow YAML - aposd-plain — skipped-by-dispatch: no code changed; only CI workflow YAML - react — skipped-by-dispatch: no React components changed; only CI workflow YAML

forgejo-actions reviewed

2026-10-27 11:59:02 +00:00

.forgejo/workflows/release.yml

					
				@ -5,1 +4,3 @@

				# managed quality suite on the merged revision before publishing.

				# Required PR status checks are intentionally disabled, so the release gate verifies

				# the merged revision before publishing: it runs the managed quality suite, or reuses

				# a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md).

low — release.yml points to ADR 0004, which does not exist in the tree

A maintainer who wants to know why the release gate may skip the quality suite follows this pointer and finds no file. The header comment in release.yml now says the gate 'runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)'. The subject tree's docs/adr/ holds only 0001-next-typegen-after-install.md, and a grep for '0004' across the tree finds no other reference to such an ADR (the only other hit is a hash in pnpm-lock.yaml). The reuse rules therefore live only in the comments in checks.yml (the reuse job header and the qc-result header), which that file does not mention as the home. Correction: either add the ADR in the same change (the rationale for trusting a pull request pass on an identical tree, the 24-hour window, and the rejected alternative of always rerunning), or drop the parenthetical and point at the reuse and qc-result jobs in checks.yml, which are the authority for the mechanism. If release.yml is rendered from a template in another repository (its error message tells the reader to run j4k-align --fix, which suggests so), correct the template, since the ADR may exist only there. I read release.yml, checks.yml and the docs/adr directory; I could not check any other repository for the ADR.

lens writing-quality · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M5YKJ8TXF09V2TT0784STV0J of review 01M5YKG50JDJD7M5SX6MCTYVT0

**low** — release.yml points to ADR 0004, which does not exist in the tree > A maintainer who wants to know why the release gate may skip the quality suite follows this pointer and finds no file. The header comment in release.yml now says the gate 'runs the managed quality suite, or reuses a pull request pass on the same tree (docs/adr/0004-forgejo-checks-reuse-same-tree-passes.md)'. The subject tree's docs/adr/ holds only 0001-next-typegen-after-install.md, and a grep for '0004' across the tree finds no other reference to such an ADR (the only other hit is a hash in pnpm-lock.yaml). The reuse rules therefore live only in the comments in checks.yml (the `reuse` job header and the `qc-result` header), which that file does not mention as the home. Correction: either add the ADR in the same change (the rationale for trusting a pull request pass on an identical tree, the 24-hour window, and the rejected alternative of always rerunning), or drop the parenthetical and point at the `reuse` and `qc-result` jobs in checks.yml, which are the authority for the mechanism. If release.yml is rendered from a template in another repository (its error message tells the reader to run `j4k-align --fix`, which suggests so), correct the template, since the ADR may exist only there. I read release.yml, checks.yml and the docs/adr directory; I could not check any other repository for the ADR. lens `writing-quality` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M5YKJ8TXF09V2TT0784STV0J` of review `01M5YKG50JDJD7M5SX6MCTYVT0`