j4k-oss/worktree-add
Watch
2
0
Fork
You've already forked worktree-add
 0
Code Issues Pull requests Releases 5 Packages 1 Activity Actions

chore: sync managed files with align 17.3.2 #15

Merged
jercik merged 1 commit from chore/align-17-3-2 into main 2026-10-27 16:36:37 +00:00
Conversation 2 Commits 1 Files changed 5 +23 -21
jercik commented 2026-10-27 16:06:12 +00:00
Owner

Syncs managed files with @j4k/align 17.3.2 (j4k-align --fix). Updates workflow and script comments to cite stable code.j4k.dev URLs.

🤖 Generated with Claude Code

Syncs managed files with `@j4k/align` 17.3.2 (`j4k-align --fix`). Updates workflow and script comments to cite stable `code.j4k.dev` URLs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
chore: sync managed files with align 17.3.2
All checks were successful
Checks / reuse (pull_request) Has been skipped
Details
Checks / pr-flow-canary (pull_request) Has been skipped
Details
commit-msg / commitlint (pull_request) Successful in 6s
Details
Checks / quality-checks (26.12.1) (pull_request) Successful in 26s
Details
Checks / quality-checks (24.15.0) (pull_request) Successful in 38s
Details
Checks / qc-result (pull_request) Has been skipped
Details
Review / Review (pull_request_target) Successful in 2m36s
Details
c7d2d7d47d
 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
forgejo-actions commented 2026-10-27 16:08:48 +00:00

Review 01M5Z1SGF9RKD5TYY2148HJQJV — head c7d2d7d47db9d7852361b632eb3ef77814d64dcc

Review — j4k-oss/worktree-add @ 0038a8ce5f

Scope: diff against base tree b1e60edb6586
Review finished: 6 succeeded, 0 failed, 4 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

medium — Reuse comment restates which pull request kinds run or skip quality-checks, a set the quality-checks if condition defines

  • claim: 01M5Z1VA7TV534WPCH707G18XA
  • anchor: .forgejo/workflows/checks.yml (snippet)
# Same-repository pull requests run quality-checks in full, and fork and AGit
  # pull requests skip it.
  • lens: restated-sets · arm: default
  • verdicts: 1 valid / 0 invalid / 0 uncertain
    • pass 01M5Z1WFR6DFGA0KZVYS0PKJEG · valid: Grounded (exact) anchor shows the reuse header sentence enumerating which pull request kinds run (same-repository) and skip (fork, AGit) quality-checks. The body names the authority, the quality-checks job's if: condition in the same file, and quotes it: run when event != pull_request or (head repo == repository && flow == 0). Comparing the lists: the condition runs same-repo flow-0 PRs and skips forks and AGit (flow != 0); the copy names same-repository (run), fork and AGit (skip). No member appears in only one list, so the copy agrees today and medium is correct. The sentence is presented as the whole rule, so a reader would take it as complete, and it restates branch conditions that writing-for-agents 'One Idea, One Place' says to point to rather than copy. No exception applies: the reuse reader's task (why a candidate run must have actually executed quality-checks) is served by the existing clause 'a run that skipped them is green but proves nothing' plus a pointer to the if: condition, which loses no needed meaning. The proposed pointer correction is appropriate.
  • duplicates: 01M5Z1VK3HDKDARCS1NGRP3VRT (aposd-plain)
  • disposition: none

The reuse job's header comment says 'Same-repository pull requests run quality-checks in full, and fork and AGit pull requests skip it.' That is an independent list of which pull request kinds run or skip the job. The comment was added in this diff. The set is defined by the if: expression on the quality-checks job in the same file: github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0'). If the condition changes (a new trusted source, a different AGit flow value), this sentence goes stale silently and nothing prompts anyone to edit it.

Comparison: the condition runs the job for non-pull_request events (the workflow_call release path), for same-repository pull requests whose flow is 0, and skips every other pull request. The copy names same-repository (runs), fork (skips) and AGit (skips). No member appears in only one list today; the copy agrees, so this is medium, not a current disagreement. The same file already carries two other copies of the skip set: the comment directly above the quality-checks if ('Fork and AGit PRs skip this job, and a skip is not a pass...') and the qc_executed comment '(a fork or AGit pull request)'. That comment sits next to the condition, so a reader of the reuse comment does not need a local copy of the list.

No exception applies. The text is not a dated record or a table of contents, and no reader task needs the enumeration at this spot. The reader here needs to know why a green run can still prove nothing, and the existing clause 'a run that skipped them is green but proves nothing' already says that. The skip rule itself is decided by the if condition.

Correction: drop the sentence and point to the authority, e.g. 'A pull request never reuses a pass. A candidate is a successful pull request run of this file ... whose quality-checks jobs actually ran and all succeeded (the quality-checks if condition decides which pull requests run it); a run that skipped them is green but proves nothing.'

Examined: the full checks.yml, the diff for all five changed files, and the quality-checks if condition and the qc_executed helper. I did not run the workflow. The base-side comment is not available beyond the diff, so I cannot say whether the removed text carried this sentence.

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (1)
    • 01M5Z1VT0D4624BDJJ8XCXXC1H low — ADR pointer drops "decision 10", so the reader must search the whole ADR for the rationale
  • duplicate-of (1)
    • 01M5Z1VK3HDKDARCS1NGRP3VRT low — The reuse job's header comment restates the quality-checks fork/AGit gate, adding a third copy of that rule → 01M5Z1VA7TV534WPCH707G18XA
  • unadjudicated (0)

Coverage

Coverage pass: 01M5Z1SGFETXB8420MM09MYAH6
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens part arm unit status runs loss
general-bug whole default no-claims 1 no
writing-quality whole default claims-emitted 1 no
restated-sets whole default claims-emitted 1 no
project-docs whole default no-claims 1 no
module-design whole default no-claims 1 no
aposd-plain whole default claims-emitted 1 no
  • test-trimming — skipped-by-dispatch: no tests changed
  • unix-cli — skipped-by-dispatch: the only change in shell is an added comment; no CLI behavior changed
  • use-effect — skipped-by-dispatch: no React code changed
  • react — skipped-by-dispatch: no React code changed
<!-- review:summary --> **Review** `01M5Z1SGF9RKD5TYY2148HJQJV` — head `c7d2d7d47db9d7852361b632eb3ef77814d64dcc` # Review — j4k-oss/worktree-add @ 0038a8ce5f1a Scope: diff against base tree `b1e60edb6586` Review finished: 6 succeeded, 0 failed, 4 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### medium — Reuse comment restates which pull request kinds run or skip quality-checks, a set the quality-checks `if` condition defines - claim: `01M5Z1VA7TV534WPCH707G18XA` - anchor: `.forgejo/workflows/checks.yml` (snippet) ``` # Same-repository pull requests run quality-checks in full, and fork and AGit # pull requests skip it. ``` - lens: restated-sets · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M5Z1WFR6DFGA0KZVYS0PKJEG` · valid: Grounded (exact) anchor shows the reuse header sentence enumerating which pull request kinds run (same-repository) and skip (fork, AGit) quality-checks. The body names the authority, the quality-checks job's if: condition in the same file, and quotes it: run when event != pull_request or (head repo == repository && flow == 0). Comparing the lists: the condition runs same-repo flow-0 PRs and skips forks and AGit (flow != 0); the copy names same-repository (run), fork and AGit (skip). No member appears in only one list, so the copy agrees today and medium is correct. The sentence is presented as the whole rule, so a reader would take it as complete, and it restates branch conditions that writing-for-agents 'One Idea, One Place' says to point to rather than copy. No exception applies: the reuse reader's task (why a candidate run must have actually executed quality-checks) is served by the existing clause 'a run that skipped them is green but proves nothing' plus a pointer to the if: condition, which loses no needed meaning. The proposed pointer correction is appropriate. - duplicates: `01M5Z1VK3HDKDARCS1NGRP3VRT` (aposd-plain) - disposition: none > The reuse job's header comment says 'Same-repository pull requests run quality-checks in full, and fork and AGit pull requests skip it.' That is an independent list of which pull request kinds run or skip the job. The comment was added in this diff. The set is defined by the `if:` expression on the `quality-checks` job in the same file: `github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0')`. If the condition changes (a new trusted source, a different AGit flow value), this sentence goes stale silently and nothing prompts anyone to edit it. > > Comparison: the condition runs the job for non-pull_request events (the workflow_call release path), for same-repository pull requests whose flow is 0, and skips every other pull request. The copy names same-repository (runs), fork (skips) and AGit (skips). No member appears in only one list today; the copy agrees, so this is medium, not a current disagreement. The same file already carries two other copies of the skip set: the comment directly above the `quality-checks` `if` ('Fork and AGit PRs skip this job, and a skip is not a pass...') and the `qc_executed` comment '(a fork or AGit pull request)'. That comment sits next to the condition, so a reader of the reuse comment does not need a local copy of the list. > > No exception applies. The text is not a dated record or a table of contents, and no reader task needs the enumeration at this spot. The reader here needs to know why a green run can still prove nothing, and the existing clause 'a run that skipped them is green but proves nothing' already says that. The skip rule itself is decided by the `if` condition. > > Correction: drop the sentence and point to the authority, e.g. 'A pull request never reuses a pass. A candidate is a successful pull request run of this file ... whose quality-checks jobs actually ran and all succeeded (the `quality-checks` `if` condition decides which pull requests run it); a run that skipped them is green but proves nothing.' > > Examined: the full checks.yml, the diff for all five changed files, and the `quality-checks` `if` condition and the `qc_executed` helper. I did not run the workflow. The base-side comment is not available beyond the diff, so I cannot say whether the removed text carried this sentence. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M5Z1VT0D4624BDJJ8XCXXC1H` low — ADR pointer drops "decision 10", so the reader must search the whole ADR for the rationale - duplicate-of (1) - `01M5Z1VK3HDKDARCS1NGRP3VRT` low — The `reuse` job's header comment restates the `quality-checks` fork/AGit gate, adding a third copy of that rule → `01M5Z1VA7TV534WPCH707G18XA` - unadjudicated (0) ## Coverage Coverage pass: 01M5Z1SGFETXB8420MM09MYAH6 Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | restated-sets | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | no-claims | 1 | no | | module-design | whole | default | no-claims | 1 | no | | aposd-plain | whole | default | claims-emitted | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - unix-cli — skipped-by-dispatch: the only change in shell is an added comment; no CLI behavior changed - use-effect — skipped-by-dispatch: no React code changed - react — skipped-by-dispatch: no React code changed
forgejo-actions reviewed 2026-10-27 16:08:48 +00:00
.forgejo/workflows/checks.yml
Lines 47-48
@ -50,2 +46,3 @@
# quality-checks jobs actually ran and all succeeded; a run that skipped them
# is green but proves nothing.
# (workflow_call with release_gate) look; a pull request never reuses a pass.
# Same-repository pull requests run quality-checks in full, and fork and AGit
# pull requests skip it. A candidate is a successful pull request run of this
forgejo-actions commented 2026-10-27 16:08:48 +00:00

medium — Reuse comment restates which pull request kinds run or skip quality-checks, a set the quality-checks if condition defines

The reuse job's header comment says 'Same-repository pull requests run quality-checks in full, and fork and AGit pull requests skip it.' That is an independent list of which pull request kinds run or skip the job. The comment was added in this diff. The set is defined by the if: expression on the quality-checks job in the same file: github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0'). If the condition changes (a new trusted source, a different AGit flow value), this sentence goes stale silently and nothing prompts anyone to edit it.

Comparison: the condition runs the job for non-pull_request events (the workflow_call release path), for same-repository pull requests whose flow is 0, and skips every other pull request. The copy names same-repository (runs), fork (skips) and AGit (skips). No member appears in only one list today; the copy agrees, so this is medium, not a current disagreement. The same file already carries two other copies of the skip set: the comment directly above the quality-checks if ('Fork and AGit PRs skip this job, and a skip is not a pass...') and the qc_executed comment '(a fork or AGit pull request)'. That comment sits next to the condition, so a reader of the reuse comment does not need a local copy of the list.

No exception applies. The text is not a dated record or a table of contents, and no reader task needs the enumeration at this spot. The reader here needs to know why a green run can still prove nothing, and the existing clause 'a run that skipped them is green but proves nothing' already says that. The skip rule itself is decided by the if condition.

Correction: drop the sentence and point to the authority, e.g. 'A pull request never reuses a pass. A candidate is a successful pull request run of this file ... whose quality-checks jobs actually ran and all succeeded (the quality-checks if condition decides which pull requests run it); a run that skipped them is green but proves nothing.'

Examined: the full checks.yml, the diff for all five changed files, and the quality-checks if condition and the qc_executed helper. I did not run the workflow. The base-side comment is not available beyond the diff, so I cannot say whether the removed text carried this sentence.

lens restated-sets · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M5Z1VA7TV534WPCH707G18XA of review 01M5Z1SGF9RKD5TYY2148HJQJV

<!-- review:claim:01M5Z1VA7TV534WPCH707G18XA --> **medium** — Reuse comment restates which pull request kinds run or skip quality-checks, a set the quality-checks `if` condition defines > The reuse job's header comment says 'Same-repository pull requests run quality-checks in full, and fork and AGit pull requests skip it.' That is an independent list of which pull request kinds run or skip the job. The comment was added in this diff. The set is defined by the `if:` expression on the `quality-checks` job in the same file: `github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0')`. If the condition changes (a new trusted source, a different AGit flow value), this sentence goes stale silently and nothing prompts anyone to edit it. > > Comparison: the condition runs the job for non-pull_request events (the workflow_call release path), for same-repository pull requests whose flow is 0, and skips every other pull request. The copy names same-repository (runs), fork (skips) and AGit (skips). No member appears in only one list today; the copy agrees, so this is medium, not a current disagreement. The same file already carries two other copies of the skip set: the comment directly above the `quality-checks` `if` ('Fork and AGit PRs skip this job, and a skip is not a pass...') and the `qc_executed` comment '(a fork or AGit pull request)'. That comment sits next to the condition, so a reader of the reuse comment does not need a local copy of the list. > > No exception applies. The text is not a dated record or a table of contents, and no reader task needs the enumeration at this spot. The reader here needs to know why a green run can still prove nothing, and the existing clause 'a run that skipped them is green but proves nothing' already says that. The skip rule itself is decided by the `if` condition. > > Correction: drop the sentence and point to the authority, e.g. 'A pull request never reuses a pass. A candidate is a successful pull request run of this file ... whose quality-checks jobs actually ran and all succeeded (the `quality-checks` `if` condition decides which pull requests run it); a run that skipped them is green but proves nothing.' > > Examined: the full checks.yml, the diff for all five changed files, and the `quality-checks` `if` condition and the `qc_executed` helper. I did not run the workflow. The base-side comment is not available beyond the diff, so I cannot say whether the removed text carried this sentence. lens `restated-sets` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M5Z1VA7TV534WPCH707G18XA` of review `01M5Z1SGF9RKD5TYY2148HJQJV`
jercik merged commit 8c2eef02ef into main 2026-10-27 16:36:37 +00:00
jercik deleted branch chore/align-17-3-2 2026-10-27 16:36:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/worktree-add!15
No description provided.