j4k-oss/worktree-remove
Watch
2
0
Fork
You've already forked worktree-remove
 0
Code Issues Pull requests Releases 2 Packages 1 Activity Actions

chore: sync managed files with align 17.3.2 #13

Merged
jercik merged 1 commit from chore/align-17-3-2 into main 2026-10-27 16:36:39 +00:00
Conversation 2 Commits 1 Files changed 5 +23 -21
jercik commented 2026-10-27 16:06:16 +00:00
Owner

Syncs managed files with @j4k/align 17.3.2 (j4k-align --fix). Updates workflow and script comments to cite stable code.j4k.dev URLs.

🤖 Generated with Claude Code

Syncs managed files with `@j4k/align` 17.3.2 (`j4k-align --fix`). Updates workflow and script comments to cite stable `code.j4k.dev` URLs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
chore: sync managed files with align 17.3.2
All checks were successful
Checks / quality-checks (24.15.0) (pull_request) Successful in 44s
Details
Checks / pr-flow-canary (pull_request) Has been skipped
Details
Checks / reuse (pull_request) Has been skipped
Details
commit-msg / commitlint (pull_request) Successful in 6s
Details
Checks / quality-checks (26.12.1) (pull_request) Successful in 21s
Details
Checks / qc-result (pull_request) Has been skipped
Details
Review / Review (pull_request_target) Successful in 3m6s
Details
7a797679a3
 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
forgejo-actions commented 2026-10-27 16:09:21 +00:00

Review 01M5Z1SK8SEKMCD1W2674F9VF0 — head 7a797679a3fa681f6961e514b69f0a255ead50d0

Review — j4k-oss/worktree-remove @ 7e68bface3

Scope: diff against base tree b3e2e4ab50a9
Review finished: 5 succeeded, 0 failed, 5 skipped by dispatch
Triage: settled
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v5",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (1)

low — Reuse-job header restates the quality-checks gate, and its "same-repository" vs "AGit" split contradicts that gate

  • claim: 01M5Z1WHZRGAGQ3HBHZQX7F659
  • anchor: .forgejo/workflows/checks.yml (snippet)
  # Same-repository pull requests run quality-checks in full, and fork and AGit
  # pull requests skip it.
  • lens: aposd-plain · arm: default
  • verdicts: 1 valid / 0 invalid / 0 uncertain
    • pass 01M5Z1WYKMB5QGWQQEABMNT19S · valid: The duplication half holds. The grounded snippet in .forgejo/workflows/checks.yml shows the diff adding a sentence to the reuse header that lists which pull requests run quality-checks: same-repository ones run, fork and AGit ones skip. The body names the source, the quality-checks job's if: in the same file, and quotes it: head.repo.full_name == github.repository && toJSON(flow) == '0'. It also quotes two existing descriptions of the same rule, the gate's own comment and the qc_executed comment ('a fork or AGit pull request'). Under the restated-sets guideline this is a maintenance copy. Changing the gate, for example to admit AGit, would leave this header stale. No exception applies: the reuse reader's task, knowing that a green pull-request run may not have run quality-checks, is already served by the next sentence ('a run that skipped them is green but proves nothing') plus a pointer to the if:. The contradiction half is overstated. The copy agrees with the source: both say AGit pull requests skip. The sentence names AGit explicitly as skipping, so a reader would not conclude that AGit pull requests get full checks. At most, 'same-repository' is loose wording, because the gate comment says AGit reuses this repo's identity. Source members: run = head repo matches AND flow 0; skip = fork (head repo differs) and AGit (flow not 0). Copy members: run = same-repository; skip = fork and AGit. No member appears in only one list. Because the copy still agrees, the restated-sets guideline rates this medium, not high. The proposed fix is sound: delete the sentence or replace it with a pointer to the quality-checks if:.
  • disposition: none

The new sentence in the reuse job's header comment gives a second description of which pull requests run quality-checks. That rule is decided by the quality-checks job's if:, so it is now described in three places: the if: and its comment ("Fork and AGit PRs skip this job, and a skip is not a pass. ... AGit flow 1 reuses this repo's identity"), and the qc_executed helper comment ("A skipped one (a fork or AGit pull request) is not a pass."). If someone changes the gate, for example to admit AGit or fork PRs, the reuse header goes stale without anyone noticing. This is the Information Leakage red flag applied to comments.

The restated version also gets the split wrong. The gate is github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0', and its own comment says AGit PRs reuse this repo's identity. So AGit PRs are same-repository PRs, and "Same-repository pull requests run quality-checks in full" is false for them. A reader who trusts the header will think every PR whose head repo matches gets full checks.

Correction: the reuse reader only needs to know that a pull-request run can be green without running quality-checks. The sentence that follows already covers this ("a run that skipped them is green but proves nothing"). Delete the new sentence, or replace it with a pointer such as "(the quality-checks if: says which pull requests skip it)". That leaves the gate condition and its comment as the only description.

What I examined: the full .forgejo/workflows/checks.yml in the subject tree. That covers the reuse header, the qc_executed comment, and the quality-checks if: expression and its comment, compared against the diff hunk that added the sentence. This is static reading only; I did not run the workflow.

Other claims

  • grounding-pending (0)
  • ungrounded (0)
  • rejected (1)
    • 01M5Z1VEWFNSA5N7Q5JDNQN9F4 low — ADR pointer in RESOLUTION_ERROR_CODES comment drops the decision number, leaving a bare URL as the sentence predicate
  • duplicate-of (0)
  • unadjudicated (0)

Coverage

Coverage pass: 01M5Z1SK8WVPM8B7WR6PER8QA8
Accounting: complete (all slots terminal; see slot results for failures)
Slot health: healthy

lens part arm unit status runs loss
general-bug whole default no-claims 1 no
writing-quality whole default claims-emitted 1 no
project-docs whole default no-claims 1 no
module-design whole default no-claims 1 no
aposd-plain whole default claims-emitted 1 no
  • test-trimming — skipped-by-dispatch: no tests changed
  • restated-sets — skipped-by-dispatch: no set or enumeration changed; only comments and a description string were reworded
  • unix-cli — skipped-by-dispatch: no CLI behavior changed; the shell hunks only change comments
  • use-effect — skipped-by-dispatch: no React Effects or Hooks in the changed paths
  • react — skipped-by-dispatch: no React components, props, or state in the changed paths
<!-- review:summary --> **Review** `01M5Z1SK8SEKMCD1W2674F9VF0` — head `7a797679a3fa681f6961e514b69f0a255ead50d0` # Review — j4k-oss/worktree-remove @ 7e68bface35b Scope: diff against base tree `b3e2e4ab50a9` Review finished: 5 succeeded, 0 failed, 5 skipped by dispatch Triage: settled Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v5", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (1) ### low — Reuse-job header restates the quality-checks gate, and its "same-repository" vs "AGit" split contradicts that gate - claim: `01M5Z1WHZRGAGQ3HBHZQX7F659` - anchor: `.forgejo/workflows/checks.yml` (snippet) ``` # Same-repository pull requests run quality-checks in full, and fork and AGit # pull requests skip it. ``` - lens: aposd-plain · arm: default - verdicts: 1 valid / 0 invalid / 0 uncertain - pass `01M5Z1WYKMB5QGWQQEABMNT19S` · valid: The duplication half holds. The grounded snippet in .forgejo/workflows/checks.yml shows the diff adding a sentence to the reuse header that lists which pull requests run quality-checks: same-repository ones run, fork and AGit ones skip. The body names the source, the quality-checks job's if: in the same file, and quotes it: head.repo.full_name == github.repository && toJSON(flow) == '0'. It also quotes two existing descriptions of the same rule, the gate's own comment and the qc_executed comment ('a fork or AGit pull request'). Under the restated-sets guideline this is a maintenance copy. Changing the gate, for example to admit AGit, would leave this header stale. No exception applies: the reuse reader's task, knowing that a green pull-request run may not have run quality-checks, is already served by the next sentence ('a run that skipped them is green but proves nothing') plus a pointer to the if:. The contradiction half is overstated. The copy agrees with the source: both say AGit pull requests skip. The sentence names AGit explicitly as skipping, so a reader would not conclude that AGit pull requests get full checks. At most, 'same-repository' is loose wording, because the gate comment says AGit reuses this repo's identity. Source members: run = head repo matches AND flow 0; skip = fork (head repo differs) and AGit (flow not 0). Copy members: run = same-repository; skip = fork and AGit. No member appears in only one list. Because the copy still agrees, the restated-sets guideline rates this medium, not high. The proposed fix is sound: delete the sentence or replace it with a pointer to the quality-checks if:. - disposition: none > The new sentence in the `reuse` job's header comment gives a second description of which pull requests run `quality-checks`. That rule is decided by the `quality-checks` job's `if:`, so it is now described in three places: the `if:` and its comment ("Fork and AGit PRs skip this job, and a skip is not a pass. ... AGit flow 1 reuses this repo's identity"), and the `qc_executed` helper comment ("A skipped one (a fork or AGit pull request) is not a pass."). If someone changes the gate, for example to admit AGit or fork PRs, the reuse header goes stale without anyone noticing. This is the Information Leakage red flag applied to comments. > > The restated version also gets the split wrong. The gate is `github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0'`, and its own comment says AGit PRs reuse this repo's identity. So AGit PRs are same-repository PRs, and "Same-repository pull requests run quality-checks in full" is false for them. A reader who trusts the header will think every PR whose head repo matches gets full checks. > > Correction: the reuse reader only needs to know that a pull-request run can be green without running quality-checks. The sentence that follows already covers this ("a run that skipped them is green but proves nothing"). Delete the new sentence, or replace it with a pointer such as "(the quality-checks `if:` says which pull requests skip it)". That leaves the gate condition and its comment as the only description. > > What I examined: the full `.forgejo/workflows/checks.yml` in the subject tree. That covers the `reuse` header, the `qc_executed` comment, and the `quality-checks` `if:` expression and its comment, compared against the diff hunk that added the sentence. This is static reading only; I did not run the workflow. ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M5Z1VEWFNSA5N7Q5JDNQN9F4` low — ADR pointer in `RESOLUTION_ERROR_CODES` comment drops the decision number, leaving a bare URL as the sentence predicate - duplicate-of (0) - unadjudicated (0) ## Coverage Coverage pass: 01M5Z1SK8WVPM8B7WR6PER8QA8 Accounting: complete (all slots terminal; see slot results for failures) Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | project-docs | whole | default | no-claims | 1 | no | | module-design | whole | default | no-claims | 1 | no | | aposd-plain | whole | default | claims-emitted | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed - restated-sets — skipped-by-dispatch: no set or enumeration changed; only comments and a description string were reworded - unix-cli — skipped-by-dispatch: no CLI behavior changed; the shell hunks only change comments - use-effect — skipped-by-dispatch: no React Effects or Hooks in the changed paths - react — skipped-by-dispatch: no React components, props, or state in the changed paths
forgejo-actions reviewed 2026-10-27 16:09:21 +00:00
.forgejo/workflows/checks.yml
Lines 47-48
@ -50,2 +46,3 @@
# quality-checks jobs actually ran and all succeeded; a run that skipped them
# is green but proves nothing.
# (workflow_call with release_gate) look; a pull request never reuses a pass.
# Same-repository pull requests run quality-checks in full, and fork and AGit
# pull requests skip it. A candidate is a successful pull request run of this
forgejo-actions commented 2026-10-27 16:09:21 +00:00

low — Reuse-job header restates the quality-checks gate, and its "same-repository" vs "AGit" split contradicts that gate

The new sentence in the reuse job's header comment gives a second description of which pull requests run quality-checks. That rule is decided by the quality-checks job's if:, so it is now described in three places: the if: and its comment ("Fork and AGit PRs skip this job, and a skip is not a pass. ... AGit flow 1 reuses this repo's identity"), and the qc_executed helper comment ("A skipped one (a fork or AGit pull request) is not a pass."). If someone changes the gate, for example to admit AGit or fork PRs, the reuse header goes stale without anyone noticing. This is the Information Leakage red flag applied to comments.

The restated version also gets the split wrong. The gate is github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0', and its own comment says AGit PRs reuse this repo's identity. So AGit PRs are same-repository PRs, and "Same-repository pull requests run quality-checks in full" is false for them. A reader who trusts the header will think every PR whose head repo matches gets full checks.

Correction: the reuse reader only needs to know that a pull-request run can be green without running quality-checks. The sentence that follows already covers this ("a run that skipped them is green but proves nothing"). Delete the new sentence, or replace it with a pointer such as "(the quality-checks if: says which pull requests skip it)". That leaves the gate condition and its comment as the only description.

What I examined: the full .forgejo/workflows/checks.yml in the subject tree. That covers the reuse header, the qc_executed comment, and the quality-checks if: expression and its comment, compared against the diff hunk that added the sentence. This is static reading only; I did not run the workflow.

lens aposd-plain · arm default · tally 1 valid / 0 invalid / 0 uncertain
claim 01M5Z1WHZRGAGQ3HBHZQX7F659 of review 01M5Z1SK8SEKMCD1W2674F9VF0

<!-- review:claim:01M5Z1WHZRGAGQ3HBHZQX7F659 --> **low** — Reuse-job header restates the quality-checks gate, and its "same-repository" vs "AGit" split contradicts that gate > The new sentence in the `reuse` job's header comment gives a second description of which pull requests run `quality-checks`. That rule is decided by the `quality-checks` job's `if:`, so it is now described in three places: the `if:` and its comment ("Fork and AGit PRs skip this job, and a skip is not a pass. ... AGit flow 1 reuses this repo's identity"), and the `qc_executed` helper comment ("A skipped one (a fork or AGit pull request) is not a pass."). If someone changes the gate, for example to admit AGit or fork PRs, the reuse header goes stale without anyone noticing. This is the Information Leakage red flag applied to comments. > > The restated version also gets the split wrong. The gate is `github.event.pull_request.head.repo.full_name == github.repository && toJSON(github.event.pull_request.flow) == '0'`, and its own comment says AGit PRs reuse this repo's identity. So AGit PRs are same-repository PRs, and "Same-repository pull requests run quality-checks in full" is false for them. A reader who trusts the header will think every PR whose head repo matches gets full checks. > > Correction: the reuse reader only needs to know that a pull-request run can be green without running quality-checks. The sentence that follows already covers this ("a run that skipped them is green but proves nothing"). Delete the new sentence, or replace it with a pointer such as "(the quality-checks `if:` says which pull requests skip it)". That leaves the gate condition and its comment as the only description. > > What I examined: the full `.forgejo/workflows/checks.yml` in the subject tree. That covers the `reuse` header, the `qc_executed` comment, and the `quality-checks` `if:` expression and its comment, compared against the diff hunk that added the sentence. This is static reading only; I did not run the workflow. lens `aposd-plain` · arm `default` · tally 1 valid / 0 invalid / 0 uncertain claim `01M5Z1WHZRGAGQ3HBHZQX7F659` of review `01M5Z1SK8SEKMCD1W2674F9VF0`
jercik merged commit c3d545fabe into main 2026-10-27 16:36:39 +00:00
jercik deleted branch chore/align-17-3-2 2026-10-27 16:36:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
j4k-oss/worktree-remove!13
No description provided.