fix: doc drift citation requirements should live with the category definitions #126

Merged

jercik merged 5 commits from fix/category-citation-definitions into main 2026-10-08 12:33:44 +00:00

Conversation 3 Commits 5 Files changed 1 +7 -7

jercik commented 2026-10-07 12:44:49 +00:00

Owner

Copy link

Moves the citation each verify-doc-drift finding category requires into that category's definition, so the per-unit audit loop no longer repeats all four categories. The adversarial verification paragraph now points at "Finding categories" instead of the loop.

Follow-up to a review finding on #113, which did not introduce the text.

🤖 Generated with Claude Code

Moves the citation each `verify-doc-drift` finding category requires into that category's definition, so the per-unit audit loop no longer repeats all four categories. The adversarial verification paragraph now points at "Finding categories" instead of the loop. Follow-up to a review finding on [#113](https://code.j4k.dev/j4k-oss/agent-skills/pulls/113), which did not introduce the text. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jercik added 1 commit 2026-10-07 12:44:49 +00:00

fix: doc drift citation requirements should live with the category definitions ... 8ee5ce959f

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jercik referenced this pull request 2026-10-07 12:45:18 +00:00

fix(skills): report unavailable release claims as unverified #113

forgejo-actions commented 2026-10-07 12:47:24 +00:00

Copy link

Review 01M4DJ004PFRRHAM8WYNFNW84K — head f25d377be95999a1c32177f7c562de12fbecee3b

Review — j4k-oss/agent-skills @ d71f04c5cf

Scope: diff against base tree f74616d5cc1f
Status: dispatched — coverage complete (4/4 slots terminal)
Facts: current review-wide projection

Computed under:

{
  "abandonment": "abandonment-v1",
  "anchor_recipe": 1,
  "batch_policy": "batch-v1",
  "coverage": "coverage-v3",
  "dispatch_policy": "dispatch-v2",
  "grounder_version": 1,
  "grounding_read_rule": "grounding-read-v1",
  "promotion_policy": "promotion-v1",
  "report": "report-v4",
  "tally": "tally-v1",
  "triage_settle": "triage-settle-v2"
}

Findings (0)

No findings survived.

Reviewed:

• general-bug (whole/default): no-claims
• writing-quality (whole/default): claims-emitted
• restated-sets (whole/default): no-claims
• project-docs (whole/default): no-claims
• test-trimming: skipped-by-dispatch — no tests changed; only a skill markdown doc was modified

Other claims

• grounding-pending (0)
• ungrounded (0)
• rejected (1)
  • 01M4DJ6418G9M8TE1WM3B4P09Y low — The catalog description carries the audit procedure before the skill is selected
• duplicate-of (0)
• unadjudicated (1)
  • 01M4DJ6PYVE8QCQMANR77NYX2Y low — The Task checklist repeats the procedures the skill already defines

Coverage

Coverage pass: 01M4DJ0HD775XNCRWC7AB38T04
Accounting: complete
Slot health: healthy

lens	part	arm	unit status	runs	loss
general-bug	whole	default	no-claims	1	no
writing-quality	whole	default	claims-emitted	1	no
restated-sets	whole	default	no-claims	1	no
project-docs	whole	default	no-claims	1	no

• test-trimming — skipped-by-dispatch: no tests changed; only a skill markdown doc was modified

<!-- review:summary --> **Review** `01M4DJ004PFRRHAM8WYNFNW84K` — head `f25d377be95999a1c32177f7c562de12fbecee3b` # Review — j4k-oss/agent-skills @ d71f04c5cf4d Scope: diff against base tree `f74616d5cc1f` Status: dispatched — coverage complete (4/4 slots terminal) Facts: current review-wide projection Computed under: ```json { "abandonment": "abandonment-v1", "anchor_recipe": 1, "batch_policy": "batch-v1", "coverage": "coverage-v3", "dispatch_policy": "dispatch-v2", "grounder_version": 1, "grounding_read_rule": "grounding-read-v1", "promotion_policy": "promotion-v1", "report": "report-v4", "tally": "tally-v1", "triage_settle": "triage-settle-v2" } ``` ## Findings (0) No findings survived. Reviewed: - general-bug (whole/default): no-claims - writing-quality (whole/default): claims-emitted - restated-sets (whole/default): no-claims - project-docs (whole/default): no-claims - test-trimming: skipped-by-dispatch — no tests changed; only a skill markdown doc was modified ## Other claims - grounding-pending (0) - ungrounded (0) - rejected (1) - `01M4DJ6418G9M8TE1WM3B4P09Y` low — The catalog description carries the audit procedure before the skill is selected - duplicate-of (0) - unadjudicated (1) - `01M4DJ6PYVE8QCQMANR77NYX2Y` low — The Task checklist repeats the procedures the skill already defines ## Coverage Coverage pass: 01M4DJ0HD775XNCRWC7AB38T04 Accounting: complete Slot health: healthy | lens | part | arm | unit status | runs | loss | | --- | --- | --- | --- | --- | --- | | general-bug | whole | default | no-claims | 1 | no | | writing-quality | whole | default | claims-emitted | 1 | no | | restated-sets | whole | default | no-claims | 1 | no | | project-docs | whole | default | no-claims | 1 | no | - test-trimming — skipped-by-dispatch: no tests changed; only a skill markdown doc was modified

🚀 1

jercik referenced this pull request 2026-10-07 22:00:35 +00:00

fix: point doc drift output at the audit loop citation rules #127

jercik added 2 commits 2026-10-08 08:44:32 +00:00

Merge remote-tracking branch 'origin/main' into fix/category-citation-definitions ... c04dc3b0e3

# Conflicts:
#	skills/verify-doc-drift/SKILL.md

Merge remote-tracking branch 'origin/main' into fix/category-citation-definitions 7b1328079a

jercik commented 2026-10-08 08:44:45 +00:00

Author

Owner

Copy link

Replying to the review summary (review 01M4B6ACAV0807KMEJERSNRCQ2, head 8ee5ce959f1a9f6ce7f58f8c8cd2f5dfd487b2d4)

The Output paragraph's restated citation mapping, finding 01M4B6BECA83VJR2DNC8C02MRZ and its two duplicates, is already fixed on main by de47351 (#127), which points Output at the per-unit audit loop. The merge into this branch (7b13280) carries that change, and the loop sentence now defers to "Finding categories", so Output still resolves to the single home. The same merge repoints the verification paragraph, which named the loop, to "Finding categories". No unadjudicated claims were raised.

> Replying to the review summary (review `01M4B6ACAV0807KMEJERSNRCQ2`, head `8ee5ce959f1a9f6ce7f58f8c8cd2f5dfd487b2d4`) The Output paragraph's restated citation mapping, finding `01M4B6BECA83VJR2DNC8C02MRZ` and its two duplicates, is already fixed on `main` by de47351 (#127), which points Output at the per-unit audit loop. The merge into this branch (7b13280) carries that change, and the loop sentence now defers to "Finding categories", so Output still resolves to the single home. The same merge repoints the verification paragraph, which named the loop, to "Finding categories". No unadjudicated claims were raised.

jercik added 1 commit 2026-10-08 10:47:13 +00:00

Merge remote-tracking branch 'origin/main' into fix/category-citation-definitions 2996621ae8

jercik added 1 commit 2026-10-08 10:47:20 +00:00

fix: doc drift output should point at the finding categories ... f25d377be9

The output section still named the audit loop as the home of the
per-category citation rule, which now lives under Finding categories.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jercik commented 2026-10-08 11:17:24 +00:00

Author

Owner

Copy link

Replying to the review summary (review 01M4DJ004PFRRHAM8WYNFNW84K, head f25d377be95999a1c32177f7c562de12fbecee3b)

Unadjudicated claim 01M4DJ6PYVE8QCQMANR77NYX2Y (low), "The Task checklist repeats the procedures the skill already defines": not a defect, and not in this PR's scope. The # Task section (SKILL.md lines 74-80) is untouched by this PR's diff. Its five steps are a short ordered index of the workflow, and each adds content beyond the sections it points to (step 1's ground-truth anchors, step 4's direction on doc-vs-code forks, step 5's sweep of siblings and formatter run). No follow-up PR.

> Replying to the review summary (review `01M4DJ004PFRRHAM8WYNFNW84K`, head `f25d377be95999a1c32177f7c562de12fbecee3b`) Unadjudicated claim `01M4DJ6PYVE8QCQMANR77NYX2Y` (low), "The Task checklist repeats the procedures the skill already defines": not a defect, and not in this PR's scope. The `# Task` section (SKILL.md lines 74-80) is untouched by this PR's diff. Its five steps are a short ordered index of the workflow, and each adds content beyond the sections it points to (step 1's ground-truth anchors, step 4's direction on doc-vs-code forks, step 5's sweep of siblings and formatter run). No follow-up PR.

jercik merged commit d152f38358 into main 2026-10-08 12:33:44 +00:00

jercik deleted branch fix/category-citation-definitions 2026-10-08 12:33:44 +00:00

jercik referenced this pull request from a commit 2026-10-08 12:33:44 +00:00

fix: doc drift citation requirements should live with the category definitions (#126)

jercik referenced this pull request 2026-10-08 12:34:29 +00:00

fix: refutation pass should re-derive evidence of any category #122

jercik referenced this pull request 2026-10-08 12:35:42 +00:00

fix(skills): report unavailable release claims as unverified #113

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

j4k-oss/agent-skills!126

No description provided.