chore: remove npm-mirror leftovers after align 9.0.0 #2
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/remove-npm-mirror"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Removes the npm-mirror leftovers after align 9.0.0, since the package no longer publishes to npmjs.
release.ymlloses 465 lines (10 added): thenpm-mirrorjob, its integrity step and the npmjs OIDC gating. It still publishes@j4k-oss/askpplxto the Forge registry. The GitHubrelease-npm.ymlworkflow and the.npm-mirrormarker are deleted, and align refreshed the files it manages (AGENTS.md, twocheck-dtsscripts, a workflow comment).The README now installs and runs
@j4k-oss/askpplxwith--@j4k-oss:registry=https://code.j4k.dev/api/packages/j4k-oss/npm/, because the@j4k-ossscope on npmjs has an unconfirmed owner. The unscopedaskpplxis frozen at its last version.🤖 Generated with Claude Code
Review
01M5JB35CPX68KNP17XM903HBQ— headc8cdc249d7cf2eb581b3244941e113a37a21894eReview — j4k-oss/askpplx @
ad954a979aScope: diff against base tree
1bac5930d248Status: dispatched — coverage complete (5/5 slots terminal)
Facts: current review-wide projection
Computed under:
Findings (1)
low — The agent rule overstates what
--helpverifies01M5JB9YZH19YGN43TNH0MS427README.md(snippet)01M5JBCB772S9ZBC9R1CNNMSPK· valid: The exact-grounded README sentence says askpplx --help verifies that the CLI is configured properly. The reviewer reports a specific static trace: src/cli.ts calls formatRequiresHelpText(getPerplexityApiKey()); src/config.ts retrieves an environment or stored string without authentication; src/format-requires-help-text.ts labels any nonempty string configured and shows its suffix; API requests occur on the separate src/run-cli.ts query path. Those implementation details are reviewer-supplied evidence, not independently grounded source, but coherently establish that an invalid nonempty key can satisfy this check. The instruction therefore gives an agent a false assurance of readiness. I reassessed the matching historical allegation and its valid rationale; it supplies no concrete refutation, and there is no owner closure or conflicting evidence. Low severity is appropriate. Narrowing the sentence to availability, options, and key presence preserves its operational instruction and corrects the assurance. The CLI standard does not require adding authentication to help.Other claims
01M5JBB609TPWGW1F57KSYAMCAmedium — The repoq rule independently counts the tool's write commandsCoverage
Coverage pass: 01M5JB3NQBTE10XMRM4VT1706R
Accounting: complete
Slot health: healthy
@ -72,3 +85,3 @@# Rule: Use `askpplx` for Current FactsAt the start of each session, run `npx -y askpplx --help` to verify the CLI is available and configured properly and check available options.At the start of each session, run `askpplx --help` to verify the CLI is available and configured properly and check available options.low — The agent rule overstates what
askpplx --helpverifieslens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M5JA6T84HS6J4EMEZT6R6646of review01M5JA2X5MVPTWF9ZSCHH0Z4Z8Tracked in #3. The finding holds:
askpplx --helpprints the key as configured (last four characters) without any network call. With a bogus key it still printedconfigured, and only a real request failed withInvalid API key provided. The sentence predates this PR, which only changes the command in it. #3 rewrites it to claim only CLI availability, options and key presence. It edits the same line as this PR, so I will merge this PR first and then update #3.@ -72,3 +87,3 @@# Rule: Use `askpplx` for Current FactsAt the start of each session, run `npx -y askpplx --help` to verify the CLI is available and configured properly and check available options.At the start of each session, run `askpplx --help` to verify the CLI is available and configured properly and check available options.low — The agent rule overstates what
--helpverifieslens
writing-quality· armdefault· tally 1 valid / 0 invalid / 0 uncertainclaim
01M5JB9YZH19YGN43TNH0MS427of review01M5JB35CPX68KNP17XM903HBQ--help(claim01M5JB9YZH19YGN43TNH0MS427, inline #178085): valid and predates this PR. Tracked in #3.01M5JBB609TPWGW1F57KSYAMCA(the repoq guidance counts the tool's write commands): not a defect in this PR. The sentence "It also carries one write verb:pr create" is in the generatedAGENTS.md/CLAUDE.md, which align regenerated here from the shared rulerepoq/repoq-usage.md; generated files are not edited by hand. The count is accurate today: repoq registerspr createas its only write command (src/cli/register-pr-command.ts). If repoq gains another write verb, the shared rule in the align repository needs the update, which is outside these PRs.Tracked in #3, the same finding as #177968. The sentence predates this PR; #3 rewrites it to say that
askpplx --helpchecks availability, options and whether an API key is present. #3 has a one-line conflict with this PR, which I resolve there after this PR lands.